Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NxSDK 0.8.5 #225

Merged
merged 1 commit into from
Jun 23, 2019
Merged

Support NxSDK 0.8.5 #225

merged 1 commit into from
Jun 23, 2019

Conversation

hunse
Copy link
Collaborator

@hunse hunse commented Jun 6, 2019

Support the newest NxSDK in a non-backwards-compatible way. The new NxSDK adds a number of features that we plan on taking advantage of, and supporting both new and old seems like an extra burden.

NOTE: Do not merge this until AFTER the next release, so that we have a released nengo_loihi (0.7.0) that works with NxSDK 0.8.0/1.

The driver stuff has changed quite a bit, so rather than try
to update PatchedDriver, I removed it for now.
Copy link
Member

@tbekolay tbekolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the only rub is that the driver stuff changed a lot and it wasn't clear where to patch compileDir, or if it was even possible as it gets changed before using it. So rather than futz with that I just removed that block as it's mostly here for our testing anyway. We can always add it back if we're experiencing lots of hardware test failures.

@tbekolay tbekolay merged commit 3fb62bf into master Jun 23, 2019
@tbekolay tbekolay deleted the nxsdk085 branch June 23, 2019 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants