Support NxSDK 0.8.5 #225
Merged
Support NxSDK 0.8.5 #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunse
force-pushed
the
nxsdk085
branch
2 times, most recently
from
11d1ebe to
ca540e2
Compare
The driver stuff has changed quite a bit, so rather than try to update PatchedDriver, I removed it for now.
tbekolay
approved these changes
Jun 23, 2019
Member
tbekolay
left a comment
tbekolay
left a comment
There was a problem hiding this comment.
LGTM, the only rub is that the driver stuff changed a lot and it wasn't clear where to patch compileDir, or if it was even possible as it gets changed before using it. So rather than futz with that I just removed that block as it's mostly here for our testing anyway. We can always add it back if we're experiencing lots of hardware test failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the newest NxSDK in a non-backwards-compatible way. The new NxSDK adds a number of features that we plan on taking advantage of, and supporting both new and old seems like an extra burden.
NOTE: Do not merge this until AFTER the next release, so that we have a released nengo_loihi (0.7.0) that works with NxSDK 0.8.0/1.