Obfuscate nxsdk information #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunse
reviewed
Jun 10, 2019
hunse
reviewed
Jun 10, 2019
hunse
reviewed
Jun 10, 2019
hunse
reviewed
Jun 10, 2019
tbekolay
force-pushed
the
obfuscate
branch
5 times, most recently
from
0c9b587 to
1756408
Compare
This decouples Nengo Loihi from NxSDK in preparation for obfuscating the NxCore API.
The test failure seems to be a very small floating point difference that doesn't happen in earlier TensorFlow versions, so we downgrade for now and will look into the differences in more detail later.
This seems to be the underlying issue when two processes attempt to build Loihi models at the same time. Reproducing the error and fully debugging it is time consuming, so we're adding these print statements in for now so that if the tests randomly fail again we can get some more insight for further debugging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intel has requested that we obfuscate information related to the
nxsdkAPI (since it is not publicly available). This is an attempt at doing so.Note that the goal here is not to make the obfuscated information unrecoverable, but simply to obscure it from a surface viewing.
There are three major things I was considering in the obfuscation:
nxsdkobjectsnengo-loihiclasses/functions/variables that directly correspond to equivalentnxsdkobjectsnxsdk