Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Sparse transforms #240

Merged
merged 2 commits into from
Aug 6, 2019
Merged

Implement Sparse transforms #240

merged 2 commits into from
Aug 6, 2019

Conversation

hunse
Copy link
Collaborator

@hunse hunse commented Jul 26, 2019

Support Sparse transforms for on-chip connections.

Also uses sparse matrices when possible for node->neuron and neuron->neuron connections that have a scalar or diagonal transform.

@drasmuss drasmuss force-pushed the sparse-transforms branch 2 times, most recently from ee00573 to 54c7b16 Compare August 1, 2019 16:17
Copy link
Member

@drasmuss drasmuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some minor fixups, and then two discussion comments for larger changes.

nengo_loihi/utils/sparse_matrix.py Outdated Show resolved Hide resolved
nengo_loihi/utils/sparse_matrix.py Outdated Show resolved Hide resolved
@drasmuss
Copy link
Member

drasmuss commented Aug 1, 2019

Oh, I also rebased this onto #241

Copy link
Member

@drasmuss drasmuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some more fixups to simplify the sparse logic by adding scipy as a required dependency, get diff coverage up to 100%, and fixed a minor issue with unused imports I noticed while doing that. With that last batch of fixups, this looks good to me!

Copy link
Member

@tbekolay tbekolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, merging.

Oh, right the one thing this is missing is a changelog entry for the scipy requirement. I'll add that as I clean up the history.

hunse and others added 2 commits August 6, 2019 12:06
Also use sparse matrices when possible for node->neuron and
neuron->neuron connections.

Note that scipy is now a requirement for nengo-loihi.

Co-authored-by: Daniel Rasmussen <daniel.rasmussen@appliedbrainresearch.com>
We don't need __future__ anymore since we're Python 3 only.

Enable the pylint unused-imports check now that these are fixed.
@tbekolay tbekolay merged commit e15e02b into master Aug 6, 2019
@tbekolay tbekolay deleted the sparse-transforms branch August 6, 2019 17:07
@arvoelke
Copy link
Contributor

arvoelke commented Aug 14, 2019

Should the documentation be sync'd up to reflect scipy dependency now? Edit: Created an issue (#244).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants