Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NxSDK 0.9.0 #255

Merged
merged 3 commits into from
Nov 25, 2019
Merged

NxSDK 0.9.0 #255

merged 3 commits into from
Nov 25, 2019

Conversation

hunse
Copy link
Collaborator

@hunse hunse commented Oct 22, 2019 •
edited
Loading

Support NxSDK 0.9.0. No changes are actually required, but we now do not warn for and test against 0.9.0.

I also updated HardwareInterface to store the min and max NxSDK versions on the class, so these can be checked. We now no longer have to remember to update the test in hardware/tests/test_interface.py each time we change the NxSDK version.

Depends on #234.

@hunse hunse force-pushed the nxsdk090 branch 2 times, most recently from 88ba522 to ad9a353 Compare October 30, 2019 20:35
@hunse hunse force-pushed the nxsdk090 branch 2 times, most recently from 630761c to d4b0523 Compare November 13, 2019 15:37
@hunse hunse mentioned this pull request Nov 15, 2019
Merged
@hunse
Copy link
Collaborator Author

hunse commented Nov 15, 2019 •
edited
Loading

TODO:

  • There are a number of warnings that functions we're using are now deprecated with NxSDK 0.9.0. Go through the test suite warnings and move over to the new functions where appropriate. (I believe all these new functions were available in 0.8.7 too, so hopefully backwards compatibility is not an issue. If it is, I guess we'll just do separate releases for 0.8.7 and 0.9.0, and have the 0.9.0 one not be backwards compatible.)

@hunse hunse force-pushed the nxsdk090 branch 2 times, most recently from b3f1856 to 9d27ddd Compare November 20, 2019 15:40
@hunse hunse mentioned this pull request Nov 20, 2019
Closed
hunse and others added 2 commits November 22, 2019 14:21
@hunse @tbekolay
Support NxSDK 0.8.7
1d9b29f 
Not backwards compatible with previous versions.
@hunse @tbekolay
Support NxSDK 0.9.0
14634a5
tbekolay
tbekolay approved these changes Nov 23, 2019
View reviewed changes
Copy link
Member

@tbekolay tbekolay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I didn't test this on NxSDK 0.8.7, but from the diff not much changed, and I expect most aren't using old NxSDK versions, so merging this in.

@tbekolay
Update installation instructions
9350a64 
Also adds a starting section to every changelog section stating
the versions of NxSDK that this Nengo Loihi version is compatible
with.
@tbekolay tbekolay merged commit 9350a64 into master Nov 25, 2019
@tbekolay tbekolay deleted the nxsdk090 branch November 25, 2019 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbekolay tbekolay tbekolay approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hunse @tbekolay