Conversation
hunse
force-pushed
the
nxsdk090
branch
2 times, most recently
from
88ba522 to
ad9a353
Compare
hunse
force-pushed
the
nxsdk090
branch
2 times, most recently
from
630761c to
d4b0523
Compare
Merged
Contributor
Author
|
TODO:
|
hunse
force-pushed
the
nxsdk090
branch
2 times, most recently
from
b3f1856 to
9d27ddd
Compare
Closed
Not backwards compatible with previous versions.
tbekolay
approved these changes
Nov 23, 2019
Member
tbekolay
left a comment
tbekolay
left a comment
There was a problem hiding this comment.
LGTM! I didn't test this on NxSDK 0.8.7, but from the diff not much changed, and I expect most aren't using old NxSDK versions, so merging this in.
Also adds a starting section to every changelog section stating the versions of NxSDK that this Nengo Loihi version is compatible with.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support NxSDK 0.9.0. No changes are actually required, but we now do not warn for and test against 0.9.0.
I also updated
HardwareInterfaceto store the min and max NxSDK versions on the class, so these can be checked. We now no longer have to remember to update the test inhardware/tests/test_interface.pyeach time we change the NxSDK version.Depends on #234.