Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NxSDK 0.9.0 #255

Merged
merged 3 commits into from Nov 25, 2019

Conversation

@hunse
Copy link
Collaborator

hunse commented Oct 22, 2019

Support NxSDK 0.9.0. No changes are actually required, but we now do not warn for and test against 0.9.0.

I also updated HardwareInterface to store the min and max NxSDK versions on the class, so these can be checked. We now no longer have to remember to update the test in hardware/tests/test_interface.py each time we change the NxSDK version.

Depends on #234.

@hunse hunse force-pushed the nxsdk090 branch from 3bf15f4 to dd457fa Oct 23, 2019
@hunse hunse force-pushed the nxsdk090 branch 2 times, most recently from 88ba522 to ad9a353 Oct 30, 2019
@hunse hunse force-pushed the nxsdk090 branch 2 times, most recently from 630761c to d4b0523 Nov 13, 2019
@hunse hunse mentioned this pull request Nov 15, 2019
@hunse

This comment has been minimized.

Copy link
Collaborator Author

hunse commented Nov 15, 2019

TODO:

  • There are a number of warnings that functions we're using are now deprecated with NxSDK 0.9.0. Go through the test suite warnings and move over to the new functions where appropriate. (I believe all these new functions were available in 0.8.7 too, so hopefully backwards compatibility is not an issue. If it is, I guess we'll just do separate releases for 0.8.7 and 0.9.0, and have the 0.9.0 one not be backwards compatible.)
@hunse hunse force-pushed the nxsdk090 branch 2 times, most recently from b3f1856 to 9d27ddd Nov 19, 2019
@hunse hunse mentioned this pull request Nov 20, 2019
hunse added 2 commits Jul 3, 2019
Not backwards compatible with previous versions.
@tbekolay tbekolay force-pushed the nxsdk090 branch from 9d27ddd to 14634a5 Nov 22, 2019
Copy link
Member

tbekolay left a comment

LGTM! I didn't test this on NxSDK 0.8.7, but from the diff not much changed, and I expect most aren't using old NxSDK versions, so merging this in.

Also adds a starting section to every changelog section stating
the versions of NxSDK that this Nengo Loihi version is compatible
with.
@tbekolay tbekolay merged commit 9350a64 into master Nov 25, 2019
3 checks passed
3 checks passed
Travis CI - Branch Build Passed
Details
codecov/patch 100% of diff hit (target 100%)
Details
codecov/project Absolute coverage decreased by -0.35% but relative coverage increased by +1.04% compared to 01c9885
Details
@tbekolay tbekolay deleted the nxsdk090 branch Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.