Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests in Python 3.6 by default #258

merged 2 commits into from Nov 20, 2019

Run tests in Python 3.6 by default #258

merged 2 commits into from Nov 20, 2019


Copy link

@hunse hunse commented Nov 5, 2019

This ensures that black static checks get run (black does not support Python 3.5, which is what we used previously).

The hardware tests still use Python 3.5.2, because this is required by NxSDK.

This also adds a commit that fixes the scipy.sparse import errors (#252).

hunse added 2 commits Nov 20, 2019
Some import statements just imported `scipy` when we needed
`scipy.sparse`. Import order differences made this an occasional

Fixes #252.
This allows us to do a proper `bones-check` with `black`.
The hardware tests are still in 3.5.2 to support NxSDK.
Copy link

@tbekolay tbekolay left a comment

Added a quick changelog entry for the bugfix. LGTM, merging!

@tbekolay tbekolay merged commit a97bf76 into master Nov 20, 2019
3 checks passed
@tbekolay tbekolay deleted the python36-test branch Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants