Run tests in Python 3.6 by default #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some import statements just imported `scipy` when we needed `scipy.sparse`. Import order differences made this an occasional bug. Fixes #252.
This allows us to do a proper `bones-check` with `black`. The hardware tests are still in 3.5.2 to support NxSDK.
tbekolay
force-pushed
the
python36-test
branch
from
04b3afd to
a97bf76
Compare
tbekolay
approved these changes
Nov 20, 2019
Member
tbekolay
left a comment
tbekolay
left a comment
There was a problem hiding this comment.
Added a quick changelog entry for the bugfix. LGTM, merging!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that
blackstatic checks get run (blackdoes not support Python 3.5, which is what we used previously).The hardware tests still use Python 3.5.2, because this is required by NxSDK.
This also adds a commit that fixes the
scipy.sparseimport errors (#252).