Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate to support recent versions of various packages #259
Conversation
drasmuss
force-pushed the
version-updates
branch
2 times, most recently
from
dffede0
to
1e77c32
tbekolay
force-pushed the
version-updates
branch
6 times, most recently
from
5fa5415
to
5be42b4
|
Got the tests passing with a few TODOs for when the NengoDL 3.0.0 release happens. Merging! |
This comment has been minimized.
This comment has been minimized.
|
The coverage changes are due to no longer covering some compatibility stuff as none of the TravisCI jobs use Nengo 2.8.0 anymore. I made #263 to discuss that so that this PR isn't blocked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
drasmuss commentedNov 8, 2019
This brings Nengo Loihi up-to-date with Nengo core, Nengo Bones, Nengo DL, and TensorFlow.
Note that this depends on a PR in Nengo DL (nengo/nengo-dl#108) and Nengo Extras (nengo/nengo-extras#90).
I didn't do the Nengo DL updates in a backwards compatible way. We could probablyyyy make it work if we wanted to, but it'd be pretty messy. And since Nengo Loihi is a pretty rapidly changing project, requiring users to upgrade their Nengo DL installation doesn't seem too bad.