Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to support recent versions of various packages #259

Merged
merged 4 commits into from Nov 20, 2019
Merged

Conversation

@drasmuss
Copy link
Member

drasmuss commented Nov 8, 2019

This brings Nengo Loihi up-to-date with Nengo core, Nengo Bones, Nengo DL, and TensorFlow.

Note that this depends on a PR in Nengo DL (nengo/nengo-dl#108) and Nengo Extras (nengo/nengo-extras#90).

I didn't do the Nengo DL updates in a backwards compatible way. We could probablyyyy make it work if we wanted to, but it'd be pretty messy. And since Nengo Loihi is a pretty rapidly changing project, requiring users to upgrade their Nengo DL installation doesn't seem too bad.

@drasmuss drasmuss force-pushed the version-updates branch 2 times, most recently from dffede0 to 1e77c32 Nov 8, 2019
@drasmuss drasmuss force-pushed the version-updates branch from 6e38a31 to fc6c384 Nov 12, 2019
@tbekolay tbekolay force-pushed the version-updates branch 6 times, most recently from 5fa5415 to 5be42b4 Nov 16, 2019
@tbekolay tbekolay force-pushed the version-updates branch from 5be42b4 to cd0ea00 Nov 20, 2019
Copy link
Member

tbekolay left a comment

Got the tests passing with a few TODOs for when the NengoDL 3.0.0 release happens. Merging!

@tbekolay

This comment has been minimized.

Copy link
Member

tbekolay commented Nov 20, 2019

The coverage changes are due to no longer covering some compatibility stuff as none of the TravisCI jobs use Nengo 2.8.0 anymore. I made #263 to discuss that so that this PR isn't blocked.

@tbekolay tbekolay merged commit cd0ea00 into master Nov 20, 2019
1 of 3 checks passed
1 of 3 checks passed
codecov/patch 93.93% of diff hit (target 100%)
Details
codecov/project 98.95% (-0.53%) compared to 4b56bb1
Details
Travis CI - Branch Build Passed
Details
@tbekolay tbekolay deleted the version-updates branch Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.