Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install NengoDL neuron builders on neuron init #275

Merged
merged 4 commits into from Mar 20, 2020
Merged

Conversation

hunse
Copy link
Collaborator

@hunse hunse commented Mar 18, 2020

This insures that the NengoDL neuron builders are added even if
a nengo_loihi.Simulator has not yet been created (e.g. if they're
being used for training in NengoDL first).

Fixes #248.

@hunse hunse force-pushed the dl-builder-import branch 3 times, most recently from 1a3e91c to 4b874df Compare March 18, 2020 18:57
Copy link
Member

@drasmuss drasmuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some minor fixups, if those look good to you I'll merge.

@hunse
Copy link
Collaborator Author

hunse commented Mar 20, 2020

LGTM!

Treat it as a scalar 1, which will result in diagonal weights
(this is the most minimal weights available on Loihi).

Introduce `is_transform_type` helper function to determine the
transform type across any version of Nengo (e.g. for Nengo <= 3.0.0
where `NoTransform` does not yet exist).
`LoihiLIF.rates` was already using discretized `tau_rc`, so now the
`step_math` function will match.

The tolerances for `test_conv_connection` have been loosened for
the floating-point emulator, which does not round `tau_rc`,
and therefore will no longer be as close.
This insures that the NengoDL neuron builders are added even if
a `nengo_loihi.Simulator` has not yet been created (e.g. if they're
being used for training in NengoDL first).
@drasmuss drasmuss merged commit 96a46a4 into master Mar 20, 2020
@drasmuss drasmuss deleted the dl-builder-import branch March 20, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Loihi neuron type nengo_dl builders not used by default
2 participants