Install NengoDL neuron builders on neuron init #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunse
force-pushed
the
dl-builder-import
branch
3 times, most recently
from
1a3e91c to
4b874df
Compare
drasmuss
force-pushed
the
dl-builder-import
branch
from
184ae34 to
f04851b
Compare
drasmuss
approved these changes
Mar 19, 2020
Member
drasmuss
left a comment
drasmuss
left a comment
There was a problem hiding this comment.
Made some minor fixups, if those look good to you I'll merge.
hunse
commented
Mar 20, 2020
hunse
commented
Mar 20, 2020
Contributor
Author
|
LGTM! |
drasmuss
force-pushed
the
dl-builder-import
branch
from
f480cf1 to
ac61601
Compare
Treat it as a scalar 1, which will result in diagonal weights (this is the most minimal weights available on Loihi). Introduce `is_transform_type` helper function to determine the transform type across any version of Nengo (e.g. for Nengo <= 3.0.0 where `NoTransform` does not yet exist).
`LoihiLIF.rates` was already using discretized `tau_rc`, so now the `step_math` function will match. The tolerances for `test_conv_connection` have been loosened for the floating-point emulator, which does not round `tau_rc`, and therefore will no longer be as close.
This insures that the NengoDL neuron builders are added even if a `nengo_loihi.Simulator` has not yet been created (e.g. if they're being used for training in NengoDL first).
drasmuss
force-pushed
the
dl-builder-import
branch
from
ac61601 to
96a46a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This insures that the NengoDL neuron builders are added even if
a
nengo_loihi.Simulatorhas not yet been created (e.g. if they'rebeing used for training in NengoDL first).
Fixes #248.