Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install NengoDL neuron builders on neuron init #275

Merged
merged 4 commits into from Mar 20, 2020
Merged

Conversation

@hunse
Copy link
Collaborator

hunse commented Mar 18, 2020

This insures that the NengoDL neuron builders are added even if
a nengo_loihi.Simulator has not yet been created (e.g. if they're
being used for training in NengoDL first).

Fixes #248.

@hunse hunse force-pushed the dl-builder-import branch 3 times, most recently from 1a3e91c to 4b874df Mar 18, 2020
@drasmuss drasmuss force-pushed the dl-builder-import branch from 184ae34 to f04851b Mar 19, 2020
Copy link
Member

drasmuss left a comment

Made some minor fixups, if those look good to you I'll merge.

@hunse

This comment has been minimized.

Copy link
Collaborator Author

hunse commented Mar 20, 2020

LGTM!

@drasmuss drasmuss force-pushed the dl-builder-import branch from f480cf1 to ac61601 Mar 20, 2020
hunse added 4 commits Mar 18, 2020
`LoihiLIF.rates` was already using discretized `tau_rc`, so now the
`step_math` function will match.

The tolerances for `test_conv_connection` have been loosened for
the floating-point emulator, which does not round `tau_rc`,
and therefore will no longer be as close.
This insures that the NengoDL neuron builders are added even if
a `nengo_loihi.Simulator` has not yet been created (e.g. if they're
being used for training in NengoDL first).
Treat it as a scalar 1, which will result in diagonal weights
(this is the most minimal weights available on Loihi).

Introduce `is_transform_type` helper function to determine the
transform type across any version of Nengo (e.g. for Nengo <= 3.0.0
where `NoTransform` does not yet exist).
@drasmuss drasmuss force-pushed the dl-builder-import branch from ac61601 to 96a46a4 Mar 20, 2020
@drasmuss drasmuss merged commit 96a46a4 into master Mar 20, 2020
3 checks passed
3 checks passed
Travis CI - Branch Build Passed
Details
codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 99.57% (+<.01%) compared to 5280436
Details
@drasmuss drasmuss deleted the dl-builder-import branch Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.