Conversation
drasmuss
approved these changes
Apr 13, 2020
Member
drasmuss
left a comment
drasmuss
left a comment
There was a problem hiding this comment.
Just added a changelog entry, looks good
- Wrong index used for slice in `split_probe`. - `compartment_idxs` must be an array to allow `probe.slice` to be an index array in `hardware.builder.build_probe`. - Probe weights were not configured properly when the probe target was an `ObjView`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
split_probe.compartment_idxsmust be an array to allowprobe.sliceto be an index array in
hardware.builder.build_probe.was an
ObjView.