Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix split/sliced probe bugs #284

Merged
merged 1 commit into from Apr 13, 2020
Merged

Fix split/sliced probe bugs #284

merged 1 commit into from Apr 13, 2020

Conversation

hunse
Copy link
Collaborator

@hunse hunse commented Apr 9, 2020

  • Wrong index used for slice in split_probe.
  • compartment_idxs must be an array to allow probe.slice
    to be an index array in hardware.builder.build_probe.
  • Probe weights were not configured properly when the probe target
    was an ObjView.

Copy link
Member

@drasmuss drasmuss left a comment

Just added a changelog entry, looks good

- Wrong index used for slice in `split_probe`.
- `compartment_idxs` must be an array to allow `probe.slice`
  to be an index array in `hardware.builder.build_probe`.
- Probe weights were not configured properly when the probe target
  was an `ObjView`.
@drasmuss drasmuss merged commit 944c0e2 into master Apr 13, 2020
2 of 3 checks passed
@drasmuss drasmuss deleted the cifar10 branch Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants