Conversation
hunse
force-pushed
the
error-objects
branch
2 times, most recently
from
561fb77 to
da956d5
Compare
Merged
tbekolay
force-pushed
the
error-objects
branch
from
b19eb04 to
bd006da
Compare
tbekolay
approved these changes
Nov 30, 2021
Member
tbekolay
left a comment
tbekolay
left a comment
There was a problem hiding this comment.
Rebased and pushed a fixup to change the modified strings to f-strings. It's fine to leave the ones already in the codebase, but ideally we would change them all, so might as well have the newly touched ones use f-strings. Will squash and merge when CI finishes.
It is almost always the case that a BuildError is associated with building a particular object, and specifying the object makes it easier to track down.
tbekolay
force-pushed
the
error-objects
branch
from
bd006da to
77a2a98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is almost always the case that a BuildError is associated with
building a particular object, and specifying the object makes it
easier to track down.