-
Notifications
You must be signed in to change notification settings - Fork 11
Nengomaster #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Nengomaster #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
db5521b
to
5343f7a
Compare
1 task
drasmuss
reviewed
Oct 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed some minor fixups, and then a few questions below.
drasmuss
reviewed
Oct 16, 2020
Fixups LGTM |
hunse
commented
Oct 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
And fix pylint errors in lmu.ipynb and keyword-spotting.ipynb
The LoihiLIF gradient tests are passing again. Test with released NengoDL
b3911b4
to
621dfb4
Compare
Merged
621dfb4
to
4f66d9f
Compare
We are currently not set up to initialize voltages on the chip, so better to keep this all zero. Also: - Use zero voltage for decode neurons (we could relax this in the future, but for now it gets things working the way they used to). - Rename `step_math` to `step` so custom neuron types work. - Fixed connection seeding.
These are not permitted in Nengo, so we now match that behaviour. (We used to give a warning and convert to Dense.)
On NxSDK 0.9.8, multichip tests (using snips or not, i.e. either value of `precompute`) have problems on Nahuku08. Some Nahuku32 boards hang if started without the skip-power option, so always pass that option when starting Nahuku32. Also xfail multi-chip learning tests, because they sometimes fail on the chip due to some sort of timeout, and the chip receiving an unexpected shutdown signal.
Drop support for Nengo 3.0
We previously had implemented this for createProcess, but we now use createSnip everywhere.
Was unable to find a good weight exponent because the initial weights were very small. This may have been a problem for a while, with a lucky seed saving us from the error. Using larger initial weights (by setting the transform) avoids the error.
ecb76dc
to
7ff801d
Compare
drasmuss
approved these changes
Nov 27, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get working with Nengo
master