Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DVS input from files #306

Merged
merged 1 commit into from Jan 14, 2021
Merged

Support DVS input from files #306

merged 1 commit into from Jan 14, 2021

Conversation

hunse
Copy link
Collaborator

@hunse hunse commented Dec 22, 2020

This allows loading DVS input from either .aedat or .events files and sending it to the chip.

@hunse hunse force-pushed the file-dvs branch 3 times, most recently from 4b17935 to 9ff4a99 Compare December 23, 2020 14:19
@hunse hunse mentioned this pull request Dec 23, 2020
.templates/docs.sh.template Outdated Show resolved Hide resolved
docs/examples/dvs-from-file.ipynb Show resolved Hide resolved
docs/examples/dvs-from-file.ipynb Show resolved Hide resolved
docs/examples/dvs-from-file.ipynb Show resolved Hide resolved
docs/examples/dvs-from-file.ipynb Outdated Show resolved Hide resolved
docs/examples/dvs-from-file.ipynb Show resolved Hide resolved
nengo_loihi/__init__.py Outdated Show resolved Hide resolved
nengo_loihi/builder/inputs.py Outdated Show resolved Hide resolved
nengo_loihi/builder/inputs.py Outdated Show resolved Hide resolved
nengo_loihi/builder/inputs.py Outdated Show resolved Hide resolved
@hunse
Copy link
Collaborator Author

hunse commented Jan 8, 2021

Ok, I think I've addressed all of the comments. I ended up making a ChipProcess class; any nodes with a process subclassed from this will be put on the chip. This keeps things cleaner in the builder (we care about this in the connection builder, in addition to in the splitter). It also makes it possible for users to add their own chip processes, and makes it easier for us in the future if we want to add more.

I got rid of DVSFileChipNode entirely, and renamed the process to DVSFileChipProcess so it should be clear that it's sending spikes directly to the chip (I also made a note about this in the example).

Copy link
Member

@drasmuss drasmuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixups all look good to me!

Works in emulator and on-chip, but does not use the on-chip
structures required for live DVS.

Also adds a `ChipProcess` class for node processes that are
built by the NengoLoihi builder.
@drasmuss drasmuss merged commit c04376c into master Jan 14, 2021
@drasmuss drasmuss deleted the file-dvs branch January 14, 2021 21:44
@hunse hunse mentioned this pull request Jan 18, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants