Deobfuscate - #320
Merged
Merged
Conversation
tbekolay
force-pushed
the
deobfuscate
branch
from
November 30, 2021 21:29
2d6bdda to
073798b
Compare
tbekolay
approved these changes
Nov 30, 2021
tbekolay
left a comment
tbekolay
left a comment
Member
There was a problem hiding this comment.
Looks great, excited to have this in once CI finishes!
tbekolay
force-pushed
the
deobfuscate
branch
from
November 30, 2021 21:55
073798b to
f7cbd11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(based off #289)
Yay! We are no longer obfuscated!
I think this can probably all be squashed into one commit, I just wanted to keep it separate for testing (and maybe it's helpful for review, too?)
Most of the deobfuscation was performed by our automated script, but there were a few places where I had to step in with some manual changes (the biggest one being the snips).
I also went through the obfuscation commit (bcebef3), and found a few places where we were using a more "explicit" representation of a number (e.g.
2 ** 12 - 1rather than 4095), and changed those back.