Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow free tx as default on invocations #378

Merged

Conversation

3 participants
@igormcoelho
Copy link

commented Jun 1, 2019

I think that it's not necessary that neo-cli enforces a minimum fee of 0.001 on all transactions, only on those that exceed 1024 bytes.

@igormcoelho igormcoelho requested review from jsolman, vncoelho and erikzhang Jun 1, 2019

@vncoelho
Copy link
Member

left a comment

Agree brother.
I did not test. I am not so much used with neocli invokes.

Need test.

@shargon

This comment has been minimized.

Copy link
Member

commented Jun 2, 2019

give me a couple of hours for check the gas consumption

@shargon

This comment has been minimized.

Show resolved Hide resolved neo-cli/Shell/MainService.cs Outdated
@shargon Fixed8.Zero
Co-Authored-By: Shargon <shargon@gmail.com>
@shargon

shargon approved these changes Jun 3, 2019

@igormcoelho

This comment has been minimized.

Copy link
Author

commented Jun 3, 2019

Thanks for testing @shargon, I'll try to improve testing capabilities of neo-cli in a next commit.

@igormcoelho igormcoelho merged commit e04e881 into neo-project:master-2.x Jun 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@igormcoelho igormcoelho deleted the igormcoelho:zero_fee_default_invokes branch Jun 3, 2019

@igormcoelho

This comment has been minimized.

Copy link
Author

commented Jun 3, 2019

@erikzhang a more complete testing structure is proposed here: #382

@jseagrave21 jseagrave21 referenced this pull request Jun 11, 2019

Merged

Implement SimplePolicyPlugin in Transaction.Verify #964

5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.