Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for OnInvoke neo-cli #382

Merged
merged 12 commits into from Jun 10, 2019

Conversation

3 participants
@igormcoelho
Copy link

commented Jun 3, 2019

I guess we can separate a few methods to guarantee better testability directly on neo-cli project.

igormcoelho added some commits Jun 3, 2019

@igormcoelho igormcoelho requested review from vncoelho, shargon and erikzhang Jun 3, 2019

@igormcoelho

This comment has been minimized.

Copy link
Author

commented Jun 3, 2019

@erikzhang @shargon this effectively creates a template which we can easily use for future testings.

Show resolved Hide resolved tests/protocol.json Outdated
Show resolved Hide resolved tests/.gitignore Outdated
Show resolved Hide resolved neo-cli/Shell/MainService.cs Outdated
@igormcoelho

This comment has been minimized.

Copy link
Author

commented Jun 5, 2019

@erikzhang @shargon this is the complete template for tests, I just removed any other extra change.
I have some ideas for good testing here, but I guess we should start applying these on Neo 3.0 first (neo-cli 3.x).

Show resolved Hide resolved .gitignore Outdated

vncoelho added some commits Jun 9, 2019

@erikzhang erikzhang merged commit c4c4c7e into neo-project:master-2.x Jun 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.