Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ping nodes while show state #391

merged 4 commits into from Jun 17, 2019


3 participants
Copy link

commented Jun 16, 2019

Related to neo-project/neo#832
Close #287

@shargon shargon requested a review from erikzhang Jun 16, 2019

while (!stop)
system.LocalNode.Tell(Message.Create(MessageCommand.Ping, PingPayload.Create(Blockchain.Singleton.Height)));
await Task.Delay(Blockchain.TimePerBlock);

This comment was marked as resolved.

Copy link

erikzhang Jun 17, 2019


We should use CancellationToken here. Otherwise we will have to wait at most 15 seconds to exit from the loop.

@shargon shargon requested a review from erikzhang Jun 17, 2019

Copy link

left a comment

Nice, @shargon, this will be a good info while showing state.

We can calibrate it better when the client 3.0 reach preview.

erikzhang added some commits Jun 17, 2019

@erikzhang erikzhang merged commit bd472a3 into neo-project:master Jun 17, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress

@shargon shargon deleted the shargon:ping-nodes branch Jun 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.