Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import multisigaddress method on solo chain #393

Merged
merged 1 commit into from Jun 23, 2019

Conversation

3 participants
@superboyiii
Copy link
Contributor

commented Jun 18, 2019

Don't need at least 5 elements for the command of import multisigaddress on solo chain.

Fix import multisigaddress method on solo chain
Don't need 5 elements for the command of import multisigaddress on solo chain.
@vncoelho
Copy link
Member

left a comment

That is true, @superboyiii, even a single public key can be used.

What do you mean by solo chain?

@superboyiii

This comment has been minimized.

Copy link
Contributor Author

commented Jun 18, 2019

That's your works, hahaha! #703 Single CN. I just made a name for that. @vncoelho

@vncoelho

This comment has been minimized.

Copy link
Member

commented Jun 18, 2019

Aehuaheuaheaea, I got it...

I never used the neo-cli for multi-sig. I will build the client and test, then approve it. Maybe it take 1-3 days until I can focus on it, but I will check it out.

If someone could test it before.

@superboyiii

This comment has been minimized.

Copy link
Contributor Author

commented Jun 18, 2019

On master branch (NEO3.X), it's already applied on. I just sync it to the latest.

@superboyiii

This comment has been minimized.

Copy link
Contributor Author

commented Jun 18, 2019

I've tested it before on NEO3.0.

@vncoelho

This comment has been minimized.

Copy link
Member

commented Jun 23, 2019

Sorry for the delay. Testing it now.

@vncoelho
Copy link
Member

left a comment

@superboyiii.

I tested the logic and looks ok (errors are shown when parameters are wrong), but I am still getting error when creating any multisig:

neo> import multisigaddress 1 031a6c6fbbdf02ca351745fa86b9ba5a9452d785ac4f7fc2b7548ca2a46c4fcf4a
error
neo>
@vncoelho
Copy link
Member

left a comment

Updated, it is working, I created a wallet and forgot the extension, then has not actually been created.

A wallet opened was still missing.

However, the error message should be improved because it was not reporting any wallet open issue.
It was probably reaching wallet.Save(); because the default wallet was not NEP6.

@vncoelho vncoelho merged commit 7420ccc into master-2.x Jun 23, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@vncoelho vncoelho deleted the fix-importMulti-on-soloChain branch Jun 23, 2019

@superboyiii

This comment has been minimized.

Copy link
Contributor Author

commented Jun 23, 2019

Updated, it is working, I created a wallet and forgot the extension, then has not actually been created.

A wallet opened was still missing.

However, the error message should be improved because it was not reporting any wallet open issue.
It was probably reaching wallet.Save(); because the default wallet was not NEP6.

Yes, that's correct. We should approve the 'error' message to help developers know the wrong point.

KickSeason added a commit to KickSeason/neo-cli that referenced this pull request Jun 25, 2019

Merge pull request #1 from neo-project/master-2.x
Fix import multisigaddress method on solo chain (neo-project#393)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.