update to support new neo #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LTE->LE GTE->GT syscall change
xswap chain->reverse
arraysize->size
fix 1 32addr conv bug
"System.ExecutionEngine.GetScriptContainer"->"System.Runtime.GetScriptContainer" 2.fix new biginteger op pass all unittest for compiler now.
neo-vm do not allow shift <0
…neo-project/neo-devpack-dotnet into Branch_lights_matchopcodechange
add contact.callex in framework.
lightszero
requested review from
shargon,
erikzhang and
lock9
and removed request for
shargon and
erikzhang
|
I will help you with UT |
shargon
reviewed
Jan 15, 2020
| @@ -679,15 +682,15 @@ private int ConvertCode(ILMethod method, OpCode src, NeoMethod to) | |||
| case CodeEx.Brtrue: | |||
| case CodeEx.Brtrue_S: | |||
| { | |||
| var code = _Convert1by1(VM.OpCode.JMPIF, src, to, new byte[] { 0, 0 }); | |||
| var code = _Convert1by1(VM.OpCode.JMPIF_L, src, to, new byte[] { 0, 0, 0, 0 }); | |||
There was a problem hiding this comment.
We should use JMPIF if the address is less than one byte
There was a problem hiding this comment.
we can do that on other pr
shargon
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #181
finish it.
can merge now.
And need help for fix the native unittest?I am not familiar with that.
@neo-project/core