Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GUI according to latest charge policy. #284

Merged
merged 7 commits into from Jun 17, 2019

Conversation

5 participants
@Lichen9618
Copy link
Contributor

commented Jun 12, 2019

  1. Add Net fee for Invocation transaction
  2. Update dependency to NEO 2.10.2
  3. Add specific address to claim gas window for #282

Lichen9618 added some commits May 9, 2019

Add unit in cost remind window
Sum Net fee and System fee in Cost warning window.
在消耗提示窗口中,加总了网络费和系统费。

Add dynamic net fee in Cost Warning window

Update Neo.dll version to 2.10.2.1

claim to address

Adjust time of net fee creation

Adjust decorate transaction sequence

Add input to claim gas part
//
this.combo_address.FormattingEnabled = true;
resources.ApplyResources(this.combo_address, "combo_address");
this.combo_address.Name = "combo_address";

This comment has been minimized.

Copy link
@shargon

shargon Jun 13, 2019

Member
Suggested change
this.combo_address.Name = "combo_address";
this.combo_address.Name = "combo_address";
this.combo_address.DropDownStyle = System.Windows.Forms.ComboBoxStyle.DropDownList;

This comment has been minimized.

Copy link
@Lichen9618

Lichen9618 Jun 13, 2019

Author Contributor

We should have further discussion about that.

If we change the ComboBoxStyle to DropDownList
this.combo_address.DropDownStyle = System.Windows.Forms.ComboBoxStyle.DropDownList;

Claim gas can not input manually.

In some cases:
Users would like to claim gas to cold wallet.
they have to make one more transaction.

By the way, there is "scripthash" check for manually input address. prevent safe problem.

How are about your suggestion?
Regards.

This comment has been minimized.

Copy link
@shargon

shargon Jun 13, 2019

Member

you can add your cold address in your wallet, what do you think?

@superboyiii

This comment has been minimized.

Copy link

commented Jun 13, 2019

@shargon Hey, Shargon, cold address should not been add to network available environment. And some address even is crypitographic. For example: Ledger. We should make these address be able to be claimed to.

@superboyiii superboyiii reopened this Jun 13, 2019

@shargon

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

But you can add this address as watch only

@superboyiii

This comment has been minimized.

Copy link

commented Jun 13, 2019

This could make it more complex. And neo-cli also has a free changeAddress option when use "claim gas" command. Ordinary user use neo-gui to send asset, most of them even don't know watch address could be added.

@@ -736,7 +745,7 @@
</COMReference>
</ItemGroup>
<ItemGroup>
<PackageReference Include="Neo" Version="2.10.1" />
<PackageReference Include="Neo" Version="2.10.2.1" />

This comment has been minimized.

Copy link
@erikzhang

erikzhang Jun 15, 2019

Member

Why 2.10.2.1?

This comment has been minimized.

Copy link
@Lichen9618

Lichen9618 Jun 17, 2019

Author Contributor

Because it is the latest stable version from NuGet.
And in test, it works fine.

Is there any possible problem?

@@ -17,14 +18,14 @@ public partial class ClaimForm : Form
public ClaimForm()
{
InitializeComponent();
this.ClientSize = new System.Drawing.Size(400, 180);

This comment has been minimized.

Copy link
@erikzhang

erikzhang Jun 17, 2019

Member

Should set size in resource file.

@shargon shargon merged commit 3c4ae9a into neo-project:master Jun 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.