From d71a4707fb980fc863acb22df3f1fade66bf731d Mon Sep 17 00:00:00 2001 From: Luchuan Date: Sun, 22 Mar 2020 19:25:50 +0800 Subject: [PATCH] Replace THROWIFNOT by ASSERT (#1475) --- .../ApplicationEngine.OpCodePrices.cs | 4 ++-- src/neo/Wallets/Wallet.cs | 2 +- src/neo/neo.csproj | 2 +- .../Network/P2P/Payloads/UT_Transaction.cs | 14 +++++++------- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/neo/SmartContract/ApplicationEngine.OpCodePrices.cs b/src/neo/SmartContract/ApplicationEngine.OpCodePrices.cs index 29552e4397..4bfa5775bf 100644 --- a/src/neo/SmartContract/ApplicationEngine.OpCodePrices.cs +++ b/src/neo/SmartContract/ApplicationEngine.OpCodePrices.cs @@ -59,8 +59,8 @@ partial class ApplicationEngine [OpCode.CALL_L] = 22000, [OpCode.CALLA] = 22000, [OpCode.THROW] = 30, - [OpCode.THROWIF] = 30, - [OpCode.THROWIFNOT] = 30, + [OpCode.ABORT] = 30, + [OpCode.ASSERT] = 30, [OpCode.RET] = 0, [OpCode.SYSCALL] = 0, [OpCode.DEPTH] = 60, diff --git a/src/neo/Wallets/Wallet.cs b/src/neo/Wallets/Wallet.cs index c0bf012c2a..722c4dadea 100644 --- a/src/neo/Wallets/Wallet.cs +++ b/src/neo/Wallets/Wallet.cs @@ -255,7 +255,7 @@ public Transaction MakeTransaction(TransferOutput[] outputs, UInt160 from = null foreach (var (account, value) in balances_used) { sb.EmitAppCall(output.AssetId, "transfer", account, output.ScriptHash, value); - sb.Emit(OpCode.THROWIFNOT); + sb.Emit(OpCode.ASSERT); } } if (assetId.Equals(NativeContract.GAS.Hash)) diff --git a/src/neo/neo.csproj b/src/neo/neo.csproj index 85efaaf594..6b06ca6960 100644 --- a/src/neo/neo.csproj +++ b/src/neo/neo.csproj @@ -27,7 +27,7 @@ - + diff --git a/tests/neo.UnitTests/Network/P2P/Payloads/UT_Transaction.cs b/tests/neo.UnitTests/Network/P2P/Payloads/UT_Transaction.cs index 679103a470..339df5605e 100644 --- a/tests/neo.UnitTests/Network/P2P/Payloads/UT_Transaction.cs +++ b/tests/neo.UnitTests/Network/P2P/Payloads/UT_Transaction.cs @@ -324,7 +324,7 @@ public void FeeIsSignatureContract_TestScope_Global() // self-transfer of 1e-8 GAS System.Numerics.BigInteger value = (new BigDecimal(1, 8)).Value; sb.EmitAppCall(NativeContract.GAS.Hash, "transfer", acc.ScriptHash, acc.ScriptHash, value); - sb.Emit(OpCode.THROWIFNOT); + sb.Emit(OpCode.ASSERT); script = sb.ToArray(); } @@ -417,7 +417,7 @@ public void FeeIsSignatureContract_TestScope_CurrentHash_GAS() // self-transfer of 1e-8 GAS System.Numerics.BigInteger value = (new BigDecimal(1, 8)).Value; sb.EmitAppCall(NativeContract.GAS.Hash, "transfer", acc.ScriptHash, acc.ScriptHash, value); - sb.Emit(OpCode.THROWIFNOT); + sb.Emit(OpCode.ASSERT); script = sb.ToArray(); } @@ -511,7 +511,7 @@ public void FeeIsSignatureContract_TestScope_CalledByEntry_Plus_GAS() // self-transfer of 1e-8 GAS System.Numerics.BigInteger value = (new BigDecimal(1, 8)).Value; sb.EmitAppCall(NativeContract.GAS.Hash, "transfer", acc.ScriptHash, acc.ScriptHash, value); - sb.Emit(OpCode.THROWIFNOT); + sb.Emit(OpCode.ASSERT); script = sb.ToArray(); } @@ -606,7 +606,7 @@ public void FeeIsSignatureContract_TestScope_CurrentHash_NEO_FAULT() // self-transfer of 1e-8 GAS System.Numerics.BigInteger value = (new BigDecimal(1, 8)).Value; sb.EmitAppCall(NativeContract.GAS.Hash, "transfer", acc.ScriptHash, acc.ScriptHash, value); - sb.Emit(OpCode.THROWIFNOT); + sb.Emit(OpCode.ASSERT); script = sb.ToArray(); } @@ -666,7 +666,7 @@ public void FeeIsSignatureContract_TestScope_CurrentHash_NEO_GAS() // self-transfer of 1e-8 GAS System.Numerics.BigInteger value = (new BigDecimal(1, 8)).Value; sb.EmitAppCall(NativeContract.GAS.Hash, "transfer", acc.ScriptHash, acc.ScriptHash, value); - sb.Emit(OpCode.THROWIFNOT); + sb.Emit(OpCode.ASSERT); script = sb.ToArray(); } @@ -763,7 +763,7 @@ public void FeeIsSignatureContract_TestScope_NoScopeFAULT() // self-transfer of 1e-8 GAS System.Numerics.BigInteger value = (new BigDecimal(1, 8)).Value; sb.EmitAppCall(NativeContract.GAS.Hash, "transfer", acc.ScriptHash, acc.ScriptHash, value); - sb.Emit(OpCode.THROWIFNOT); + sb.Emit(OpCode.ASSERT); script = sb.ToArray(); } @@ -1023,7 +1023,7 @@ public void FeeIsSignatureContract_TestScope_Global_Default() // self-transfer of 1e-8 GAS System.Numerics.BigInteger value = (new BigDecimal(1, 8)).Value; sb.EmitAppCall(NativeContract.GAS.Hash, "transfer", acc.ScriptHash, acc.ScriptHash, value); - sb.Emit(OpCode.THROWIFNOT); + sb.Emit(OpCode.ASSERT); script = sb.ToArray(); }