Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract Guid by counter #1405

Merged
merged 24 commits into from Jan 17, 2020
Merged

Conversation

@doubiliu
Copy link
Contributor

doubiliu commented Jan 10, 2020

Use global counters to implement Guid.

doubiliu added 5 commits Jan 9, 2020
src/neo/Ledger/ContractState.cs Outdated Show resolved Hide resolved
src/neo/Ledger/StorageKey.cs Outdated Show resolved Hide resolved
src/neo/Persistence/ClonedView.cs Outdated Show resolved Hide resolved
src/neo/Persistence/ReadOnlyView.cs Outdated Show resolved Hide resolved
src/neo/Ledger/GlobalVariableState.cs Outdated Show resolved Hide resolved
src/neo/Persistence/StoreView.cs Outdated Show resolved Hide resolved
@shargon

This comment has been minimized.

Copy link
Member

shargon commented Jan 13, 2020

It's ready to review?

doubiliu added 3 commits Jan 14, 2020
@doubiliu doubiliu changed the title Contract guid fix Contract Guid by counter Jan 14, 2020
@doubiliu doubiliu marked this pull request as ready for review Jan 14, 2020
doubiliu added 2 commits Jan 14, 2020
src/neo/Persistence/Prefixes.cs Outdated Show resolved Hide resolved
src/neo/Persistence/ReadOnlyView.cs Outdated Show resolved Hide resolved
src/neo/Persistence/StoreView.cs Outdated Show resolved Hide resolved
src/neo/SmartContract/InteropService.Contract.cs Outdated Show resolved Hide resolved
src/neo/Ledger/ContractState.cs Outdated Show resolved Hide resolved
src/neo/Ledger/ContractIdState.cs Outdated Show resolved Hide resolved
src/neo/Ledger/ContractIdState.cs Outdated Show resolved Hide resolved
src/neo/Ledger/StorageKey.cs Outdated Show resolved Hide resolved
src/neo/SmartContract/InteropService.Contract.cs Outdated Show resolved Hide resolved
src/neo/SmartContract/InteropService.Contract.cs Outdated Show resolved Hide resolved
src/neo/SmartContract/Native/NativeContract.cs Outdated Show resolved Hide resolved
doubiliu and others added 5 commits Jan 14, 2020
Co-Authored-By: Erik Zhang <erik@neo.org>
Co-Authored-By: Erik Zhang <erik@neo.org>
Co-Authored-By: Erik Zhang <erik@neo.org>
Co-Authored-By: Erik Zhang <erik@neo.org>
Co-Authored-By: Erik Zhang <erik@neo.org>
doubiliu and others added 2 commits Jan 14, 2020
Copy link
Member

vncoelho left a comment

I think that we can merge this one for moving forward and improve the other opened PR.

doubiliu added 2 commits Jan 15, 2020
Review
doubiliu and others added 2 commits Jan 16, 2020
Co-Authored-By: Erik Zhang <erik@neo.org>
@erikzhang erikzhang dismissed their stale review Jan 17, 2020

Fixed.

@erikzhang erikzhang merged commit 9a272e1 into neo-project:contract-guid Jan 17, 2020
1 check passed
1 check passed
Test
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.