refactoring by erikzhang · Pull Request #288 · neo-project/neo

erikzhang · 2018-06-25T12:43:56Z

Refactor the code using the actor model. (Akka.NET)

Close #282
Close neo-project/neo-node#116

AshRolls · 2018-06-25T13:06:12Z

+            //        if (engine.EvaluationStack.Count != 1 || !engine.EvaluationStack.Pop().GetBoolean()) return false;
+            //    }
+            //}
+            return true;


Remove commented code if no longer used.

AshRolls · 2018-06-25T13:08:30Z

+        private readonly Dictionary<IPAddress, int> ConnectedAddresses = new Dictionary<IPAddress, int>();
+        protected readonly Dictionary<IActorRef, IPEndPoint> ConnectedPeers = new Dictionary<IActorRef, IPEndPoint>();
+        protected readonly HashSet<IPEndPoint> UnconnectedPeers = new HashSet<IPEndPoint>();
+        //TODO: badPeers


AshRolls · 2018-06-25T13:09:08Z

+                    catch { }
+                }
+                tcp.Tell(new Tcp.Bind(Self, new IPEndPoint(IPAddress.Any, ListenerPort), options: new[] { new Inet.SO.ReuseAddress(true) }));
+                //TODO: Websocket


AshRolls · 2018-06-25T13:12:36Z

+                            //    peerJson["address"] = peer.Address.ToString();
+                            //    peerJson["port"] = peer.Port;
+                            //    unconnectedPeers.Add(peerJson);
+                            //}


Commented code / TODO

AshRolls · 2018-06-25T13:12:54Z

+                            //    peerJson["address"] = peer.Address.ToString();
+                            //    peerJson["port"] = peer.Port;
+                            //    badPeers.Add(peerJson);
+                            //}


Commented Code / TODO

vncoelho · 2018-06-25T15:25:20Z

OMG, @erikzhang.

vncoelho · 2018-06-25T15:29:10Z

+                if (Blockchain.GetConsensusAddress(Blockchain.Singleton.Snapshot.GetValidators(context.Transactions.Values).ToArray()).Equals(context.NextConsensus))
                {
-                    Log($"send perpare response");
+                    Log($"send prepare response");


I was waiting for this...aehuaheuaea

vncoelho · 2018-06-25T15:32:09Z

+                            Message = Message.Create("inv", payload)
+                        });
                }
+                TimeSpan span = DateTime.Now - block_received_time;


Erik, let's consider a startup time here.

TimeSpan span = DateTime.Now + averageStartupTimeTimeOfKPreviousBlocks - block_received_time;

But, perhaps, not now, right? It would make harder to detect any different in this refactoring.

DateTime.UtcNow please

What is the difference, Sharrrgon brothers?

The important thing here would be to have something unified in terms of clock and time syncing. The template has almost not so much effects.

erikzhang · 2018-07-02T07:19:18Z

Now we can test this PR with neo-gui and neo-cli.

GUI: NEO-GUI v2.9.0 neo-gui-2.x#246
CLI: NEO-CLI v2.9.0 neo-node#188

vncoelho · 2018-07-02T13:30:15Z

Testing are starting: NeoResearch/neo-tests@95e5e49
Thanks @AshRolls 🗡️

vncoelho · 2018-07-02T13:42:18Z

Great implementation, @erikzhang, congratulations for the concise modification. Apparently, basic functionalities are working pretty smooth.
NeoCompiler is very interlaced and everything seems to be working in the desired manner.
Notoriously, I fell that things are running softer. However, it is a biased analyses. aheuahueaea

I noticed that 29 free transactions were broadcasted in a single block, perhaps, I should adjust the freemaxtransaction per block here.

We gonna check it with time and verify the boundaries defined in Neo 3.0

Checking with additional features, I am getting the following errors:

[ERROR][07/02/2018 16:48:03][Thread 0006][akka://NeoSystem/user/$b/connection_c13547dc-7bc6-48db-bdd3-0a1bd009a2f6/$a] Operation is not valid due to the current state of the object.
Cause: System.Net.ProtocolViolationException: Operation is not valid due to the current state of the object.
   at Neo.Network.P2P.ProtocolHandler.OnReceive(Object message)
   at Akka.Actor.UntypedActor.Receive(Object message)
   at Akka.Actor.ActorBase.AroundReceive(Receive receive, Object message)
   at Akka.Actor.ActorCell.ReceiveMessage(Object message)
   at Akka.Actor.ActorCell.Invoke(Envelope envelope)

[ERROR][07/02/2018 16:48:03][Thread 0010][akka://NeoSystem/system/IO-TCP/$g] Transport endpoint is not connected
Cause: System.Net.Sockets.SocketException (0x80004005): Transport endpoint is not connected
   at System.Net.Sockets.Socket.UpdateStatusAfterSocketErrorAndThrowException(SocketError error, String callerName)
   at System.Net.Sockets.Socket.get_RemoteEndPoint()
   at Akka.IO.TcpConnection.CompleteConnect(IActorRef commander, IEnumerable`1 options)
   at Akka.IO.TcpOutgoingConnection.<>c__DisplayClass12_0.<Connecting>b__0(Object message)
   at Akka.Actor.ActorBase.AroundReceive(Receive receive, Object message)
   at Akka.Actor.ActorCell.ReceiveMessage(Object message)
   at Akka.Actor.ActorCell.Invoke(Envelope envelope)

[ERROR][07/02/2018 16:48:03][Thread 0005][akka://NeoSystem/system/IO-TCP/$f] Restarting not supported for connection actors.
Cause: [akka://NeoSystem/system/IO-TCP/$f#1048723336]: Akka.Actor.PostRestartException: Exception post restart (System.Net.Sockets.SocketException) ---> Akka.Pattern.IllegalStateException: Restarting not supported for connection actors.
   at Akka.IO.TcpConnection.PostRestart(Exception reason)
   at Akka.Actor.ActorCell.UseThreadContext(Action action)
   at Akka.Actor.ActorCell.FinishRecreate(Exception cause, ActorBase failedActor)
   --- End of inner exception stack trace ---

- Microsoft.AspNetCore.ResponseCompression v2.1.1 - Microsoft.AspNetCore.Server.Kestrel v2.1.1 - Microsoft.AspNetCore.Server.Kestrel.Https v2.1.1 - Microsoft.EntityFrameworkCore.Sqlite v2.1.1 - Microsoft.Extensions.Configuration.Json v2.1.1

vncoelho · 2018-07-03T16:30:39Z

Great, Erik.

RPC calls are now responding. However, still stucked on start consensus.

Is it compulsory to include SimplePolicy.cs plugin?

erikzhang · 2018-07-03T16:33:30Z

This is a caught exception, no problem.

vncoelho · 2018-07-03T16:37:16Z

Perfect, @erikzhang, sorry for my lack of knowledge. aehuahuea
Anyway, maybe I am missing some new configuration of the config.json from neo-cli.
start consensus is stuck.

Should the ports be changed to websocket? Are them necessary now?

erikzhang · 2018-07-04T06:33:42Z

However, still stucked on start consensus.

It's not stucked, just no print log. Now the print log function is placed inside the plugin. When you enable the plugin, you can see that the log is printed on the console. You can also modify the plugin to redirect the log to another location.

vncoelho · 2018-09-11T23:39:57Z

Great work, @erikzhang.
Incredible improvements surely were held here!
Pretty stable. Good move on the backwards compatibility, @jsolman.

The last release can be found at https://github.com/NeoResearch/neo-tests/blob/master/releases/neo-release-2.9.0-preview-all-plugins.zip

jsolman · 2018-09-12T00:17:08Z

Yes, overall, it is cleaner code and there are some nice improvements. I have been having good results testing so far in PrivateNet. I'll be launching some nodes on TestNet and observing metrics and will report back some findings here within the next day or two.

jsolman · 2018-09-12T03:05:35Z

I'm experiencing an issue now where sometimes in my private net when I stop and start the server it starts syncing the chain from genesis block instead of continuing from the most recent persisted block in leveldb. Anyone else seen this?

vncoelho · 2018-09-12T11:03:39Z

@jsolman, our node did not presented sync problems, if the "index" param is added in the config ( "Index": "Index_{0}").

jsolman · 2018-09-12T15:54:05Z

@vncoelho Erik pushed a fix to the sync issue I was mentioning two hours before your comment.

jsolman · 2018-09-13T00:10:33Z

Some transactions submitted successively via sendrawtransaction to a node running this code seem to be getting lost; the node accepts all the transactions, but after waiting multiple blocks not all of them get confirmed on the consensus nodes in my private net. I'm not sure what the problem is yet, but lets get some others testing this scenario also. In my case the consensus nodes are running 2.8.0 or less

I verified the messages are being relayed from the node running this code; so this code may be fine; still not sure what is happening to the messages just yet.

jsolman · 2018-09-13T03:46:17Z

After further investigation, if I send the same 6 transactions using sendrawtransaction to the consensus node they all get confirmed without any issue. If I send them to the node running 2.9.0 and it relays them it relays them all, but only 3 or 4 out of 6 actually make it into a block. The last ones stay in the mem_pool on the 2.9.0 node getting re-verified after every block indefinitely and the consensus nodes never confirm them.

I am digging deeper to figure out why they get confirmed if sent directly to the consensus node but when using sendrawtransaction to the 2.9.0 node some never will get confirmed.

…queue after the block is persisted

jsolman

Nice job

jsolman · 2018-09-14T10:46:29Z

Sweet to see this merged!

Fixing grammar. Also added a tip regarding the missing dll when trying to use neon.

refactoring

8d0633a

erikzhang added this to the NEO 3.0 milestone Jun 25, 2018

erikzhang requested a review from shargon June 25, 2018 12:43

AshRolls reviewed Jun 25, 2018

View reviewed changes

vncoelho reviewed Jun 25, 2018

View reviewed changes

erikzhang mentioned this pull request Jun 25, 2018

Refactoring code for stability and TPS #282

Closed

shargon reviewed Jun 26, 2018

View reviewed changes

Comment thread neo/Cryptography/Base58.cs

Comment thread neo/IO/Json/JString.cs

erikzhang added 5 commits June 28, 2018 20:25

message priority

eef4231

add failure reason for sendrawtransaction (neo-project/neo-node#116)

852540c

change version: 3.0.0-preview2

9b7817d

fix bug in sendrawtransaction

e7bc99d

improve RpcServer and Plugin system

09878c1

This was referenced Jun 29, 2018

NEO-CLI v2.9.0 neo-project/neo-node#188

Merged

NEO-GUI v2.9.0 neo-project/neo-gui-2.x#246

Merged

erikzhang added 3 commits July 3, 2018 12:40

add unconnected to RPC command getpeers

c409c09

update dependencies:

95c2fd8

- Microsoft.AspNetCore.ResponseCompression v2.1.1 - Microsoft.AspNetCore.Server.Kestrel v2.1.1 - Microsoft.AspNetCore.Server.Kestrel.Https v2.1.1 - Microsoft.EntityFrameworkCore.Sqlite v2.1.1 - Microsoft.Extensions.Configuration.Json v2.1.1

add WebSocket

876e7d5

erikzhang added 2 commits July 4, 2018 15:25

minor fix

69e36a2

fix bug in Snapshot.Dispose()

dc77602

jsolman reviewed Sep 11, 2018

View reviewed changes

Comment thread neo/Ledger/Blockchain.cs Outdated

Comment thread neo/Network/P2P/Peer.cs

Comment thread neo/Network/P2P/Peer.cs

jsolman suggested changes Sep 12, 2018

View reviewed changes

Comment thread neo/Persistence/LevelDB/LevelDBStore.cs Outdated

Solve the problem of resynchronizing blocks

307b73a

jsolman reviewed Sep 13, 2018

View reviewed changes

Comment thread neo/Ledger/Blockchain.cs Outdated

Merge branch 'master' into Neo.Actor

0baace9

jsolman suggested changes Sep 13, 2018

View reviewed changes

Comment thread neo/Ledger/Blockchain.cs Outdated

erikzhang added 4 commits September 13, 2018 14:25

put unverified transactions in the memory pool back into the message …

6bedccb

…queue after the block is persisted

minor change to consensus

57aacf7

Merge branch 'master' into Neo.Actor

e53235c

Merge branch 'master' into Neo.Actor

cc69e09

jsolman previously approved these changes Sep 13, 2018

View reviewed changes

Merge branch 'master' into Neo.Actor

3be02c2

erikzhang dismissed jsolman’s stale review via 3be02c2 September 13, 2018 09:23

erikzhang and others added 3 commits September 13, 2018 17:53

Merge branch 'master' into Neo.Actor

aece82b

Update UserWallet.cs

98c5540

Update Contract.cs (#379)

5553fc2

erikzhang merged commit c64748e into master Sep 14, 2018

erikzhang deleted the Neo.Actor branch September 14, 2018 09:54

erikzhang mentioned this pull request Sep 14, 2018

Optimizing consensus syncing time #268

Closed

hal0x2328 mentioned this pull request Sep 25, 2018

RPC test invokes running out of GAS #396

Closed

Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020

Update getting-started-csharp.md (neo-project#288)

f16c472

Fixing grammar. Also added a tip regarding the missing dll when trying to use neon.

roman-khimov mentioned this pull request Aug 25, 2020

Replace message priority with multiple ports for transmission #1874

Closed

Uh oh!

Conversation

erikzhang commented Jun 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vncoelho commented Jun 25, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erikzhang commented Jul 2, 2018

Uh oh!

vncoelho commented Jul 2, 2018

Uh oh!

vncoelho commented Jul 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vncoelho commented Jul 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erikzhang commented Jul 3, 2018

Uh oh!

vncoelho commented Jul 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erikzhang commented Jul 4, 2018

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vncoelho commented Sep 11, 2018

Uh oh!

jsolman commented Sep 12, 2018

Uh oh!

jsolman commented Sep 12, 2018

Uh oh!

Uh oh!

vncoelho commented Sep 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsolman commented Sep 12, 2018

Uh oh!

jsolman commented Sep 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsolman commented Sep 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jsolman left a comment

Choose a reason for hiding this comment

Uh oh!

jsolman commented Sep 14, 2018

Uh oh!

Reviewers

Assignees

Labels

erikzhang commented Jun 25, 2018 •

edited

Loading

vncoelho commented Jul 2, 2018 •

edited

Loading

vncoelho commented Jul 3, 2018 •

edited

Loading

vncoelho commented Jul 3, 2018 •

edited

Loading

vncoelho commented Sep 12, 2018 •

edited

Loading

jsolman commented Sep 13, 2018 •

edited

Loading

jsolman commented Sep 13, 2018 •

edited

Loading