Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for Akka Mailboxes #806

Merged
merged 4 commits into from Jun 10, 2019

Conversation

3 participants
@igormcoelho
Copy link
Contributor

commented Jun 10, 2019

Useful tests for p2p protocol and all mailboxes.
Right now it's working already for Protocol Handler mailbox.

vncoelho and others added some commits Jun 9, 2019

@igormcoelho igormcoelho requested review from shargon, erikzhang and vncoelho Jun 10, 2019

@erikzhang

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

Do we need more tests for 2.x? I think we can add more tests for 3.0.

@igormcoelho

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2019

I'll backport all of them Erik, we need to have both projects solid.

@vncoelho
Copy link
Member

left a comment

@igormcoelho, such a nice and precise tests!

You are becoming a master in these UTs.

Let's include this tests on both. It will be good for the history of the project.

@igormcoelho

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2019

@shargon can we merge this?

@erikzhang I don't intend to go very deep on tests for 2.x now, the focus is on 3.0, but at least these tests validate previous changes on protocol handler and open door for future testings on other mailboxes, when necessary.

@vncoelho vncoelho merged commit 96506fc into neo-project:master-2.x Jun 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@vncoelho vncoelho deleted the igormcoelho:test_mailboxes branch Jun 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.