Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declaring timeout variables for connection #807

Merged
merged 4 commits into from Jun 11, 2019

Conversation

4 participants
@vncoelho
Copy link
Member

commented Jun 10, 2019

We are starting an effort for cleaning and improving the P2P classes.

@erikzhang, it is not related to this PR, but the ack = false; happens in SendMessage(Message message) function of the RemoteNode.cs.
After that, an OnAck() event is needed for returning it to true and enabling another sendmessage. Can this be improved?

vncoelho added some commits Jun 10, 2019

vncoelho added some commits Jun 11, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jun 11, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@9b11d15). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #807   +/-   ##
=========================================
  Coverage          ?   37.73%           
=========================================
  Files             ?      176           
  Lines             ?    12444           
  Branches          ?        0           
=========================================
  Hits              ?     4696           
  Misses            ?     7748           
  Partials          ?        0
Impacted Files Coverage Δ
neo/Network/P2P/Connection.cs 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b11d15...29e2fc9. Read the comment docs.

@vncoelho vncoelho merged commit e497d95 into master Jun 11, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@vncoelho vncoelho deleted the declare-variable-connection-timeout branch Jun 11, 2019

@erikzhang

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

Why not use const?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.