Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection const #818

Merged
merged 3 commits into from Jun 12, 2019

Conversation

4 participants
@shargon
Copy link
Member

commented Jun 12, 2019

No description provided.

@shargon shargon requested a review from erikzhang Jun 12, 2019

@shargon shargon changed the title Const Connection const Jun 12, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jun 12, 2019

Codecov Report

Merging #818 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #818      +/-   ##
==========================================
+ Coverage   37.73%   37.74%   +<.01%     
==========================================
  Files         176      176              
  Lines       12445    12443       -2     
==========================================
  Hits         4696     4696              
+ Misses       7749     7747       -2
Impacted Files Coverage Δ
neo/Network/P2P/Connection.cs 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 524ab15...0be6681. Read the comment docs.

@vncoelho

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

What about set this in the config?

@shargon shargon merged commit 50c16bd into neo-project:master Jun 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@shargon shargon deleted the shargon:fix-const branch Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.