Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tested all akka mailboxes (Neo 3) #823

Merged
merged 5 commits into from Jun 13, 2019

Conversation

3 participants
@igormcoelho
Copy link
Contributor

commented Jun 12, 2019

Ported mailbox tests from 2.x to 3.x.

@igormcoelho igormcoelho requested review from shargon and vncoelho Jun 12, 2019

igormcoelho added some commits Jun 12, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Jun 12, 2019

Codecov Report

Merging #823 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #823      +/-   ##
=========================================
+ Coverage   37.86%     38%   +0.14%     
=========================================
  Files         176     176              
  Lines       12443   12443              
=========================================
+ Hits         4711    4729      +18     
+ Misses       7732    7714      -18
Impacted Files Coverage Δ
neo/Consensus/ConsensusService.cs 15.88% <0%> (+1.78%) ⬆️
neo/Network/P2P/TaskManager.cs 18.99% <0%> (+2.23%) ⬆️
neo/Network/P2P/RemoteNode.cs 3.77% <0%> (+3.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50c16bd...31ddf8e. Read the comment docs.

@igormcoelho igormcoelho merged commit 354563d into neo-project:master Jun 13, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@igormcoelho igormcoelho deleted the igormcoelho:tests_3x_all_mailbox branch Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.