Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to parse uppercase 0X #842

Merged
merged 2 commits into from Jun 19, 2019

Conversation

4 participants
@shargon
Copy link
Member

commented Jun 18, 2019

0x01 and 0X01 should be valid

@codecov-io

This comment has been minimized.

Copy link

commented Jun 18, 2019

Codecov Report

Merging #842 into master will not change coverage.
The diff coverage is 25%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #842   +/-   ##
=======================================
  Coverage   38.39%   38.39%           
=======================================
  Files         176      176           
  Lines       12465    12465           
=======================================
  Hits         4786     4786           
  Misses       7679     7679
Impacted Files Coverage Δ
neo/UInt256.cs 54.54% <0%> (ø) ⬆️
neo/UInt160.cs 55.84% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d63f0ed...38c642a. Read the comment docs.

@igormcoelho

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

0x prefix means bigendian (worldwide standard and Neo convention). So, as long as it is parsed the same way it is printed tostring, its fine.
example:
parse 010203. Tostring 0x030201
parse 0x010203 tostring 0x010203

This is why.we need to fix neovm json tests... it is using 0x but not bigendian (see scripthash field)... I didnf say before, but now its time 😂

@erikzhang erikzhang merged commit 70bf2f5 into neo-project:master Jun 19, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@erikzhang erikzhang deleted the shargon:uppercase branch Jun 19, 2019

KickSeason added a commit to KickSeason/neo that referenced this pull request Jul 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.