Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean unused code #843

Merged
merged 4 commits into from Jun 20, 2019

Conversation

4 participants
@shargon
Copy link
Member

commented Jun 18, 2019

Clean code

@codecov-io

This comment has been minimized.

Copy link

commented Jun 18, 2019

Codecov Report

Merging #843 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #843      +/-   ##
==========================================
+ Coverage   38.45%   38.45%   +<.01%     
==========================================
  Files         176      176              
  Lines       12475    12474       -1     
==========================================
  Hits         4797     4797              
+ Misses       7678     7677       -1
Impacted Files Coverage Δ
neo/Network/P2P/TaskSession.cs 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e844108...b138024. Read the comment docs.

@erikzhang
Copy link
Member

left a comment

What's this???

@shargon

This comment has been minimized.

Copy link
Member Author

commented Jun 19, 2019

Why we need two classes one for keys and other for values? these classes have the same logic

@erikzhang

This comment has been minimized.

Copy link
Member

commented Jun 19, 2019

One returns Key() and another returns Value(). They are different.

@shargon

This comment has been minimized.

Copy link
Member Author

commented Jun 19, 2019

Ups xD thanks for your review :)

@shargon shargon closed this Jun 19, 2019

@shargon shargon force-pushed the shargon:summary-iterators branch from 87ec64e to 70bf2f5 Jun 19, 2019

@shargon shargon reopened this Jun 19, 2019

@shargon shargon changed the title Reduce iterator classes Clean unused code Jun 19, 2019

@shargon shargon requested a review from erikzhang Jun 19, 2019

@erikzhang

This comment has been minimized.

Copy link
Member

commented Jun 19, 2019

AssetDescriptor is used in neo-cli and neo-gui.

shargon added some commits Jun 19, 2019

@shargon shargon merged commit 8bc36c3 into neo-project:master Jun 20, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@shargon shargon deleted the shargon:summary-iterators branch Jun 20, 2019

KickSeason added a commit to KickSeason/neo that referenced this pull request Jul 9, 2019

Clean unused code (neo-project#843)
* Clean code

* Restore asset descriptor

* Clean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.