Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEP11: Non-fungible Token Standard #130

Merged
merged 60 commits into from Jun 30, 2021
Merged

NEP11: Non-fungible Token Standard #130

merged 60 commits into from Jun 30, 2021

Conversation

erikzhang
Copy link
Member

Originally posted by @hal0x2328 in #41.

}
</pre>

Returns the total amount of NFTs owned by the specified address.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the supposed return value of this method for divisible NFTs? They have an overloaded balanceOf which is quite obvious, but they at the same time have this one also (with owner parameter only) and if some owner has 0.5 of token A and 0.125 of token B then what is the total amount of divisible NFTs owned?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.625

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But does it have any meaning? These tokens are non-fungible and it can be like you own 0.5 of some house and 0.125 of the other, you don't own 0.625 of anything.

@EdgeDLT
Copy link

EdgeDLT commented Mar 18, 2021

I think we may benefit from a couple of amendments to the NFT metadata schema. Firstly, not all NFTs are images, they can be any form of content, such as music or a piece of writing. So maybe we should replace the "image" parameter with something more generalized (maybe "asset" or "content").

Secondly, I think we should include the content's SHA256 hash as a value in the schema. A commonly discussed problem right now in the Ethereum community is that a URI can easily be changed to point to something completely different; currently there are many cases of NFT images that are being replaced with pictures of rugs (for "rug pull").

Obviously an NFT isn't really used to actually store the original content so this issue isn't directly a problem for us, but I think it should always be possible to verify what content an NFT should point to. Therefore I think it is very important to store the hash.

@erikzhang
Copy link
Member Author

Firstly, not all NFTs are images, they can be any form of content, such as music or a piece of writing. So maybe we should replace the "image" parameter with something more generalized (maybe "asset" or "content").

image is a URI pointing to the icon of the specified NFT. It does not indicate the content. That's why we have another field tokenURI.

Secondly, I think we should include the content's SHA256 hash as a value in the schema.

The NFT metadata schema is expandable. You can add custom fields. Currently described are some well-known fields.

@shargon shargon changed the title NEP: Non-fungible Token Standard NEP11: Non-fungible Token Standard Apr 9, 2021
@erikzhang
Copy link
Member Author

Merge? Or anyone has any comments?

shargon
shargon previously approved these changes Apr 17, 2021
WyattMufson
WyattMufson previously approved these changes Apr 19, 2021
Copy link

@WyattMufson WyattMufson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's now been more than 3 years since this was started, seems ready to merge

vncoelho
vncoelho previously approved these changes Apr 19, 2021
nep-11.mediawiki Outdated Show resolved Hide resolved
@metachris
Copy link

Please merge! Will be great to have a finalised, accepted and merged standard that the community can build upon.

shargon
shargon previously approved these changes May 27, 2021
WyattMufson
WyattMufson previously approved these changes Jun 18, 2021
@WyattMufson
Copy link

@erikzhang what else is needed to merge this is in?

@erikzhang erikzhang dismissed stale reviews from WyattMufson and shargon via cb349ba June 30, 2021 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet