Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #28: Remove items from linked lists and reconnect procedure #1816

Merged
merged 11 commits into from Mar 19, 2021

Conversation

vga91
Copy link
Collaborator

@vga91 vga91 commented Feb 23, 2021

Fixes #28

One sentence summary of the change.

Proposed Changes (Mandatory)

A brief list of proposed changes in order to fix the issue:

  • added procedure apoc.refactor.deleteAndReconnect(Path, ListOfNodesToRemove, {config})
  • config relationshipSelectionStrategy: if incoming, the incoming relationship will be attached to the next node, if outcoming the outcoming relationship will be attached, if merge will be attacched a merge of incoming and outcoming relationships. With the same property name, takes precedence the incoming node.
  • config properties: Will be considered only if relationshipSelectionStrategy is merge. If discard, start node wins, vice versa if overwrite or override, or combine that create an array of incoming+outcoming properties (if both exist)

Relationship relationshipIn = filterRel.apply(node, Direction.INCOMING);
Relationship relationshipOut = filterRel.apply(node, Direction.OUTGOING);

// if terminal node
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// if terminal node
// if initial or terminal node

@@ -0,0 +1,82 @@
The examples in this section are based on the following sample graph:

Let's suppose we have a simple dataset like:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Let's suppose we have a simple dataset like:
Let's suppose we have a simple data set like:

@@ -0,0 +1,18 @@
The procedure support the following config parameters:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The procedure support the following config parameters:
The procedure supports the following config parameters:

Copy link
Contributor

@fbiville fbiville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/outcoming/outgoing/ but the rest looks good!

@fbiville fbiville merged commit 9328659 into neo4j-contrib:4.1 Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove items from linked lists and reconnect procedure
2 participants