Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fix NumberFormatException when passing in relationship params. #10

Merged
merged 1 commit into from

2 participants

@mikesname

At present the Geoff plugin isn't chopping enough off the param string when obtaining the relationship ID from a parameter like: "rel1": "/relationship/7"` so it's throwing a NumberFormatException trying to parse "/7".

@nigelsmall

Thanks for spotting this - will aim to review tonight.

@nigelsmall nigelsmall merged commit f1ed566 into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
View
2  geoff-plugin/src/main/java/org/neo4j/server/plugin/geoff/GeoffParams.java
@@ -54,7 +54,7 @@
if (value.startsWith("/node/")) {
p2.put(key, graphDB.getNodeById(Integer.parseInt(value.substring(6))));
} else if (value.startsWith("/relationship/")) {
- p2.put(key, graphDB.getNodeById(Integer.parseInt(value.substring(13))));
+ p2.put(key, graphDB.getNodeById(Integer.parseInt(value.substring(14))));
} else {
throw new IllegalArgumentException("Cannot resolve parameter: " + key);
}
Something went wrong with that request. Please try again.