From 0a407094496a0bf948f96d65e9e913c8d382a375 Mon Sep 17 00:00:00 2001 From: Neil Dewhurst Date: Wed, 28 Feb 2024 21:32:28 +0000 Subject: [PATCH 01/39] Use component title in place of version selector --- src/css/nav.css | 12 ++++++++++++ src/partials/nav-selectors.hbs | 9 +++++++++ 2 files changed, 21 insertions(+) diff --git a/src/css/nav.css b/src/css/nav.css index 5185320f..5e692777 100644 --- a/src/css/nav.css +++ b/src/css/nav.css @@ -69,6 +69,18 @@ html.is-clipped--nav { } } +.nav-product { + height: 2.5rem; + padding: 0.5rem 1.5rem; + box-shadow: 0 1px 0 var(--nav-panel-divider-color); +} + +.nav-product .nav-product-name { + font-size: 1rem; + font-weight: 700; + /* color: var(--color-docs); */ +} + .nav-panel-menu { overflow-y: scroll; display: flex; diff --git a/src/partials/nav-selectors.hbs b/src/partials/nav-selectors.hbs index b37fcc02..2166aede 100644 --- a/src/partials/nav-selectors.hbs +++ b/src/partials/nav-selectors.hbs @@ -24,6 +24,15 @@ +{{else}} +{{#unless (or @root.page.attributes.nav-hide-site-title (eq @root.page.attributes.theme 'cheat-sheet'))}} +{{#with @root.page.componentVersion}} + +{{/with}} +{{/unless}} + {{/if}} {{#if (eq page.attributes.theme 'cheat-sheet') }} From 008227627f0df715c4a12b39d146beb5f5bc82ed Mon Sep 17 00:00:00 2001 From: Adam Cowley Date: Wed, 6 Mar 2024 13:05:28 +0000 Subject: [PATCH 02/39] GraphAcademy Top-level Menu (#219) --- package-lock.json | 28 ++++++++++----------- src/partials/navbar-end.hbs | 50 +++++++++++++++++++++++++++++-------- 2 files changed, 54 insertions(+), 24 deletions(-) diff --git a/package-lock.json b/package-lock.json index 7d71e5e7..f44a0421 100644 --- a/package-lock.json +++ b/package-lock.json @@ -11,7 +11,7 @@ "dependencies": { "@antora/cli": "^2.3.3", "@antora/site-generator-default": "^2.3.3", - "@neo4j-ndl/base": "^0.8.3", + "@neo4j-ndl/base": "^2.0.0", "font-awesome": "^4.7.0" }, "devDependencies": { @@ -45,7 +45,7 @@ "gulp-vinyl-zip": "~2.2", "handlebars": "~4.7", "highlight.js": "^10.7", - "highlightjs-cypher": "^1.1", + "highlightjs-cypher": "^1.2", "husky": "^4.3.0", "js-yaml": "~3.13", "medium-zoom": "^1.0.6", @@ -1021,9 +1021,9 @@ } }, "node_modules/@neo4j-ndl/base": { - "version": "0.8.3", - "resolved": "https://registry.npmjs.org/@neo4j-ndl/base/-/base-0.8.3.tgz", - "integrity": "sha512-GwWAtPkzB7R3nIIDq5s05ct1VXAjncrv2Z6NhwiSRQe6e7iSHddVqlFAoWw6VIffXWPKzKlzZ1ebxRSfm38Gkw==" + "version": "2.7.1", + "resolved": "https://registry.npmjs.org/@neo4j-ndl/base/-/base-2.7.1.tgz", + "integrity": "sha512-jsE4Um+5lnsW2S46FRaCidkNI+Qb7QkIr1hdHQyKXisTcBxRZKC1KsJ4/6LqxqyI5qOsu8AIAzlQyjBe9MvPFw==" }, "node_modules/@nodelib/fs.scandir": { "version": "2.1.3", @@ -7725,9 +7725,9 @@ } }, "node_modules/highlightjs-cypher": { - "version": "1.1.5", - "resolved": "https://registry.npmjs.org/highlightjs-cypher/-/highlightjs-cypher-1.1.5.tgz", - "integrity": "sha512-CKHH2UwydrmXrUEv8m+URq80Mn3BdH81XG0azamJoN7ehHyy713o2W8jkIKIV18/toI4L5xiVBRgTplH6kWdfQ==", + "version": "1.2.0", + "resolved": "https://registry.npmjs.org/highlightjs-cypher/-/highlightjs-cypher-1.2.0.tgz", + "integrity": "sha512-mOY/g6R1MgXiYx07icl8nwtXCRDSy4Y9EAlDZKia8Thqe766v6cjnrD6/xWak9UXoLQfWqbHhmRmYuw0SiO+CA==", "dev": true, "dependencies": { "minimist": ">=1.2.6", @@ -18316,9 +18316,9 @@ } }, "@neo4j-ndl/base": { - "version": "0.8.3", - "resolved": "https://registry.npmjs.org/@neo4j-ndl/base/-/base-0.8.3.tgz", - "integrity": "sha512-GwWAtPkzB7R3nIIDq5s05ct1VXAjncrv2Z6NhwiSRQe6e7iSHddVqlFAoWw6VIffXWPKzKlzZ1ebxRSfm38Gkw==" + "version": "2.7.1", + "resolved": "https://registry.npmjs.org/@neo4j-ndl/base/-/base-2.7.1.tgz", + "integrity": "sha512-jsE4Um+5lnsW2S46FRaCidkNI+Qb7QkIr1hdHQyKXisTcBxRZKC1KsJ4/6LqxqyI5qOsu8AIAzlQyjBe9MvPFw==" }, "@nodelib/fs.scandir": { "version": "2.1.3", @@ -23934,9 +23934,9 @@ "dev": true }, "highlightjs-cypher": { - "version": "1.1.5", - "resolved": "https://registry.npmjs.org/highlightjs-cypher/-/highlightjs-cypher-1.1.5.tgz", - "integrity": "sha512-CKHH2UwydrmXrUEv8m+URq80Mn3BdH81XG0azamJoN7ehHyy713o2W8jkIKIV18/toI4L5xiVBRgTplH6kWdfQ==", + "version": "1.2.0", + "resolved": "https://registry.npmjs.org/highlightjs-cypher/-/highlightjs-cypher-1.2.0.tgz", + "integrity": "sha512-mOY/g6R1MgXiYx07icl8nwtXCRDSy4Y9EAlDZKia8Thqe766v6cjnrD6/xWak9UXoLQfWqbHhmRmYuw0SiO+CA==", "dev": true, "requires": { "minimist": ">=1.2.6", diff --git a/src/partials/navbar-end.hbs b/src/partials/navbar-end.hbs index c7a54d9d..176b4879 100644 --- a/src/partials/navbar-end.hbs +++ b/src/partials/navbar-end.hbs @@ -41,9 +41,9 @@ @@ -204,14 +204,6 @@ + {{else}}
-{{#with page.title}} -

{{{this}}}

-{{/with}} -{{#with (or page.attributes.role page.role)}} -
- {{#each (split-string this ' ')}} - - {{/each}} -
-{{/with}} +

{{{ page.title }}}

{{#with (or page.attributes.labels page.labels)}} From fdb00eeca24e2da0e37f2a48735cc591baea8bb3 Mon Sep 17 00:00:00 2001 From: Adam Cowley Date: Wed, 6 Mar 2024 15:03:57 +0000 Subject: [PATCH 07/39] 0.20.1 --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index bf97235d..6bcdf98f 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@neo4j/docs-ui", - "version": "0.20.0", + "version": "0.20.1", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@neo4j/docs-ui", - "version": "0.20.0", + "version": "0.20.1", "license": "MPL-2.0", "dependencies": { "@antora/cli": "^2.3.3", diff --git a/package.json b/package.json index e147d466..bbb22f70 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@neo4j/docs-ui", - "version": "0.20.0", + "version": "0.20.1", "description": "Produces the UI bundle for the Neo4j documentation site", "homepage": "https://github.com/neo4j-documentation/docs-ui", "license": "MPL-2.0", From 366142aa8e4fd1ca1bd4ff716fb16c2110e38ca4 Mon Sep 17 00:00:00 2001 From: Adam Cowley Date: Wed, 6 Mar 2024 15:05:45 +0000 Subject: [PATCH 08/39] 0.21.0 --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index 6bcdf98f..102b32ee 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@neo4j/docs-ui", - "version": "0.20.1", + "version": "0.21.0", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@neo4j/docs-ui", - "version": "0.20.1", + "version": "0.21.0", "license": "MPL-2.0", "dependencies": { "@antora/cli": "^2.3.3", diff --git a/package.json b/package.json index bbb22f70..a36f4e89 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@neo4j/docs-ui", - "version": "0.20.1", + "version": "0.21.0", "description": "Produces the UI bundle for the Neo4j documentation site", "homepage": "https://github.com/neo4j-documentation/docs-ui", "license": "MPL-2.0", From 99c10ce0ec96b69068682117588c637b3b5b2a78 Mon Sep 17 00:00:00 2001 From: Adam Cowley Date: Wed, 6 Mar 2024 15:06:57 +0000 Subject: [PATCH 09/39] 0.22.0 --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index 102b32ee..2fc8927d 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@neo4j/docs-ui", - "version": "0.21.0", + "version": "0.22.0", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@neo4j/docs-ui", - "version": "0.21.0", + "version": "0.22.0", "license": "MPL-2.0", "dependencies": { "@antora/cli": "^2.3.3", diff --git a/package.json b/package.json index a36f4e89..5397c5e6 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@neo4j/docs-ui", - "version": "0.21.0", + "version": "0.22.0", "description": "Produces the UI bundle for the Neo4j documentation site", "homepage": "https://github.com/neo4j-documentation/docs-ui", "license": "MPL-2.0", From 372a3f7f5991745ed22a9814afb00f1feadd5cde Mon Sep 17 00:00:00 2001 From: Adam Cowley Date: Wed, 6 Mar 2024 15:07:02 +0000 Subject: [PATCH 10/39] 0.23.0 --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index 2fc8927d..e51f4414 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@neo4j/docs-ui", - "version": "0.22.0", + "version": "0.23.0", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@neo4j/docs-ui", - "version": "0.22.0", + "version": "0.23.0", "license": "MPL-2.0", "dependencies": { "@antora/cli": "^2.3.3", diff --git a/package.json b/package.json index 5397c5e6..484f05de 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@neo4j/docs-ui", - "version": "0.22.0", + "version": "0.23.0", "description": "Produces the UI bundle for the Neo4j documentation site", "homepage": "https://github.com/neo4j-documentation/docs-ui", "license": "MPL-2.0", From 3a54d427d7bdb0d64d865ada6887dccd3f5d099d Mon Sep 17 00:00:00 2001 From: Adam Cowley Date: Thu, 7 Mar 2024 15:22:14 +0000 Subject: [PATCH 11/39] Use full URL for logo --- src/partials/header-content.hbs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/partials/header-content.hbs b/src/partials/header-content.hbs index 1787ace3..0f66e624 100644 --- a/src/partials/header-content.hbs +++ b/src/partials/header-content.hbs @@ -15,29 +15,29 @@ Cypher Cheat Sheet - + {{else if (eq page.attributes.theme "labs")}} Labs {{else if (eq page.attributes.theme "kb")}} - + Knowledge Base {{else if (eq page.attributes.theme "training")}} - + GraphAcademy {{else if (eq page.attributes.theme "graphgists")}} - + GraphGists {{else}} - + Developer From 2522fc6075a250881fc8229748c29edfc6be2348 Mon Sep 17 00:00:00 2001 From: Adam Cowley Date: Thu, 7 Mar 2024 15:22:23 +0000 Subject: [PATCH 12/39] 0.23.1 --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index e51f4414..d626fff0 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@neo4j/docs-ui", - "version": "0.23.0", + "version": "0.23.1", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@neo4j/docs-ui", - "version": "0.23.0", + "version": "0.23.1", "license": "MPL-2.0", "dependencies": { "@antora/cli": "^2.3.3", diff --git a/package.json b/package.json index 484f05de..51bc943f 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@neo4j/docs-ui", - "version": "0.23.0", + "version": "0.23.1", "description": "Produces the UI bundle for the Neo4j documentation site", "homepage": "https://github.com/neo4j-documentation/docs-ui", "license": "MPL-2.0", From 11e74689e63a3a4f0e2ba8002883d68d71b23435 Mon Sep 17 00:00:00 2001 From: Neil Dewhurst Date: Fri, 8 Mar 2024 18:32:21 +0000 Subject: [PATCH 13/39] Roles labels refinement (#220) Fixes a few issues in the initial implementation of #211: - adds `cluster` and `dynamic` labels - fixes padding in admonitions --- preview-src/docs-roles.adoc | 8 +++++++- src/css/labels.css | 5 +++++ src/js/60-docs-roles.js | 5 +++-- src/js/data/rolesData.json | 9 +++++++++ src/partials/header-content.hbs | 12 ++++++++---- 5 files changed, 32 insertions(+), 7 deletions(-) diff --git a/preview-src/docs-roles.adoc b/preview-src/docs-roles.adoc index 1fb6d250..3dd9d883 100644 --- a/preview-src/docs-roles.adoc +++ b/preview-src/docs-roles.adoc @@ -18,6 +18,12 @@ Flags sections as Not Available on Aura, Aura DB Enterprise, Enterprise Edition, Blocks with the appropriate roles have labels added. +[discrete] +[role="label--new-5.17 label--enterprise-edition"] +=== (Discrete) H3 AuraDB Enterprise AND Not on Aura + +Lorem ipsum dolor sit + [role=label--aura-db-enterprise label--not-on-aura] === H3 AuraDB Enterprise AND Not on Aura @@ -26,7 +32,7 @@ Lorem ipsum dolor sit Open blocks can be used to mark multiple paragraphs within a section. -[role=label--new-5.17] +[role=label--dynamic-5.17] -- Lorem ipsum dolor sit amet, consectetur adipiscing elit. Mauris eget leo nunc, nec tempus mi? Curabitur id nisl mi, ut vulputate urna. diff --git a/src/css/labels.css b/src/css/labels.css index 014aa938..87d2ad6f 100644 --- a/src/css/labels.css +++ b/src/css/labels.css @@ -10,6 +10,10 @@ flex-wrap: wrap; } +.admonitionblock > div.labels { + padding: 1rem 1rem 0.75rem; +} + .header-label-container > div.labels { display: flex; align-self: center; @@ -25,6 +29,7 @@ .header-label-container > div.labels.wrapped { margin-left: 0; + margin-top: 0.5rem; } .doc > .sect-header > h1.page:first-child:has(> .labels) { diff --git a/src/js/60-docs-roles.js b/src/js/60-docs-roles.js index 8189e7c7..4b6c867f 100644 --- a/src/js/60-docs-roles.js +++ b/src/js/60-docs-roles.js @@ -44,9 +44,10 @@ document.addEventListener('DOMContentLoaded', function () { } // get version number for version labels - if (rolesData[label].labelCategory === 'version' && labelParts[1]) { + if ((rolesData[label].labelCategory === 'version' || rolesData[label].versionText) && labelParts[1]) { labelDetails.data.version = labelParts[1] - labelDetails.text += ' in ' + labelDetails.data.version + const joinText = rolesData[label].versionText ? rolesData[label].versionText : 'in' + labelDetails.text = [labelDetails.text, joinText, labelDetails.data.version].join(' ') } return labelDetails diff --git a/src/js/data/rolesData.json b/src/js/data/rolesData.json index 176257f3..f71f2486 100644 --- a/src/js/data/rolesData.json +++ b/src/js/data/rolesData.json @@ -86,6 +86,11 @@ "labelCategory": "version", "displayText": "Discontinued" }, + "dynamic":{ + "labelCategory": "function", + "displayText": "Dynamic", + "versionText": "since" + }, "alpha":{ "labelCategory": "version", "displayText": "Alpha" @@ -184,6 +189,10 @@ "labelCategory": "environment", "displayText": "Windows" }, + "cluster":{ + "labelCategory": "function", + "displayText": "Cluster" + }, "cluster-member-core":{ "labelCategory": "function", "displayText": "CORE" diff --git a/src/partials/header-content.hbs b/src/partials/header-content.hbs index 0f66e624..e5571a0d 100644 --- a/src/partials/header-content.hbs +++ b/src/partials/header-content.hbs @@ -22,22 +22,26 @@ Labs {{else if (eq page.attributes.theme "kb")}} - + + {{!-- --}} Knowledge Base {{else if (eq page.attributes.theme "training")}} - + + {{!-- --}} GraphAcademy {{else if (eq page.attributes.theme "graphgists")}} - + + {{!-- --}} GraphGists {{else}} - + + {{!-- --}} Developer From 27489faaeb6c12130eef90a0ee1e80483fba4afa Mon Sep 17 00:00:00 2001 From: Neil Dewhurst Date: Fri, 8 Mar 2024 18:35:02 +0000 Subject: [PATCH 14/39] 0.23.2 --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index d626fff0..856e983a 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@neo4j/docs-ui", - "version": "0.23.1", + "version": "0.23.2", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@neo4j/docs-ui", - "version": "0.23.1", + "version": "0.23.2", "license": "MPL-2.0", "dependencies": { "@antora/cli": "^2.3.3", diff --git a/package.json b/package.json index 51bc943f..0e6db319 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@neo4j/docs-ui", - "version": "0.23.1", + "version": "0.23.2", "description": "Produces the UI bundle for the Neo4j documentation site", "homepage": "https://github.com/neo4j-documentation/docs-ui", "license": "MPL-2.0", From 0d148c1bf4644233ac1f4df3af8ce9a2dc7eda8f Mon Sep 17 00:00:00 2001 From: Neil Dewhurst Date: Fri, 8 Mar 2024 19:18:41 +0000 Subject: [PATCH 15/39] fix tabs bug (#221) --- src/js/08-tabs-block.js | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/src/js/08-tabs-block.js b/src/js/08-tabs-block.js index 252167e6..1e87ddae 100644 --- a/src/js/08-tabs-block.js +++ b/src/js/08-tabs-block.js @@ -213,15 +213,13 @@ document.addEventListener('DOMContentLoaded', function () { return hash && (~hash.indexOf('%') ? decodeURIComponent(hash) : hash).slice(1) } - var fragment, target, scrollTo - if ((fragment = decodeFragment(window.location.hash)) && (target = document.getElementById(fragment))) { - const langSelection = target.getAttribute('data-lang') - const tabbed = target.closest('.tabbed') - scrollTo = tabbed.querySelector(`[data-lang=${langSelection}]`) - if (scrollTo) { - switchTab({ - target: scrollTo, - }) - } + var fragment, target, langSelection, scrollTo + if ((fragment = decodeFragment(window.location.hash)) && + (target = document.getElementById(fragment)) && + (langSelection = target.getAttribute('data-lang')) && + (scrollTo = target.closest('.tabbed').querySelector(`[data-lang=${langSelection}]`))) { + switchTab({ + target: scrollTo, + }) } }) From 3587a3bcf94a7785037969c561322163812eff07 Mon Sep 17 00:00:00 2001 From: Neil Dewhurst Date: Fri, 8 Mar 2024 19:19:50 +0000 Subject: [PATCH 16/39] 0.23.3 --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index 856e983a..76e41078 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@neo4j/docs-ui", - "version": "0.23.2", + "version": "0.23.3", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@neo4j/docs-ui", - "version": "0.23.2", + "version": "0.23.3", "license": "MPL-2.0", "dependencies": { "@antora/cli": "^2.3.3", diff --git a/package.json b/package.json index 0e6db319..182adbf7 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@neo4j/docs-ui", - "version": "0.23.2", + "version": "0.23.3", "description": "Produces the UI bundle for the Neo4j documentation site", "homepage": "https://github.com/neo4j-documentation/docs-ui", "license": "MPL-2.0", From 68b2afd0f06e2f7bb5e50d1a57661c2f454c308c Mon Sep 17 00:00:00 2001 From: Stefano Ottolenghi Date: Fri, 15 Mar 2024 13:40:24 +0100 Subject: [PATCH 17/39] Add highlight.js language `parameters` as an alias for `json`, for cypher query parameters. --- src/js/vendor/highlight.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/js/vendor/highlight.js b/src/js/vendor/highlight.js index d9599693..1315ee64 100644 --- a/src/js/vendor/highlight.js +++ b/src/js/vendor/highlight.js @@ -19,6 +19,7 @@ hljs.registerLanguage('java', require('highlight.js/lib/languages/java')) hljs.registerLanguage('javascript', require('highlight.js/lib/languages/javascript')) hljs.registerLanguage('json', require('highlight.js/lib/languages/json')) + hljs.registerLanguage('parameters', require('highlight.js/lib/languages/json')) // cypher parameters hljs.registerLanguage('kotlin', require('highlight.js/lib/languages/kotlin')) hljs.registerLanguage('makefile', require('highlight.js/lib/languages/makefile')) hljs.registerLanguage('markdown', require('highlight.js/lib/languages/markdown')) From bebbc0ba04d1197c9cd8dc16aff7b6e561581cc4 Mon Sep 17 00:00:00 2001 From: Stefano Ottolenghi Date: Thu, 18 Apr 2024 09:19:34 +0200 Subject: [PATCH 18/39] Ensure `
` only has margin-bottom when block element (ex not in lists) (#222) --- src/css/doc.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/css/doc.css b/src/css/doc.css index 99e56b44..cc13f88d 100644 --- a/src/css/doc.css +++ b/src/css/doc.css @@ -1300,7 +1300,7 @@ body { border: none; } -.doc details { +.doc div > details { margin-bottom: 1.5rem; } From 01928affbf95c48850725422b59ed5abe91f2b41 Mon Sep 17 00:00:00 2001 From: Stefano Ottolenghi Date: Tue, 30 Apr 2024 10:07:41 +0200 Subject: [PATCH 19/39] Avoid autoscroll when changing tab in tabbed example. (#226) I think it's a bad UX if the page moves unexpectedly. When looking at examples, people may want to look at them together with the text leading to it, and they have to manually scroll back up to. --- src/js/06-code.js | 17 ----------------- src/js/08-tabs-block.js | 17 ----------------- 2 files changed, 34 deletions(-) diff --git a/src/js/06-code.js b/src/js/06-code.js index 9e4e0557..7f862fac 100644 --- a/src/js/06-code.js +++ b/src/js/06-code.js @@ -283,23 +283,6 @@ document.addEventListener('DOMContentLoaded', function () { el.classList.add(tabActive) }) }) - - var toolbarOffset = 0 - var toolbar = document.querySelector('.toolbar') - if (toolbar.offsetHeight) { - toolbarOffset = toolbar.offsetHeight - } - var offset = document.querySelector('.navbar').offsetHeight + toolbarOffset + 20 - - var bodyRect = document.body.getBoundingClientRect().top - var elementRect = tab.getBoundingClientRect().top - var elementPosition = elementRect - bodyRect - var offsetPosition = elementPosition - offset - - window.scrollTo({ - top: offsetPosition, - behavior: 'smooth', - }) } // Tabbed code diff --git a/src/js/08-tabs-block.js b/src/js/08-tabs-block.js index 1e87ddae..4d16b7fd 100644 --- a/src/js/08-tabs-block.js +++ b/src/js/08-tabs-block.js @@ -63,23 +63,6 @@ document.addEventListener('DOMContentLoaded', function () { }) }) - var toolbarOffset = 0 - var toolbar = document.querySelector('.toolbar') - if (toolbar.offsetHeight) { - toolbarOffset = toolbar.offsetHeight - } - var offset = document.querySelector('.navbar').offsetHeight + toolbarOffset + 20 - - var bodyRect = document.body.getBoundingClientRect().top - var elementRect = tab.getBoundingClientRect().top - var elementPosition = elementRect - bodyRect - var offsetPosition = elementPosition - offset - - window.scrollTo({ - top: offsetPosition, - behavior: 'smooth', - }) - if (sessionStorageAvailable) { window.sessionStorage.setItem('code_example_language', lang) } From 361a90d2b2f7ef1446c96c0ecfbbeb8ea61dad4c Mon Sep 17 00:00:00 2001 From: Lidia Zuin <102308961+lidiazuin@users.noreply.github.com> Date: Tue, 7 May 2024 13:17:52 +0200 Subject: [PATCH 20/39] Addition of GDS client to the Docs dropdown menu in the header (#225) --- src/partials/navbar-end.hbs | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/src/partials/navbar-end.hbs b/src/partials/navbar-end.hbs index 20ac9b06..954e2099 100644 --- a/src/partials/navbar-end.hbs +++ b/src/partials/navbar-end.hbs @@ -65,7 +65,6 @@
  • Status Codes
  • Java Reference
  • Kerberos Add-on
  • -
  • Change Data Capture (CDC)
  • @@ -93,6 +92,7 @@ Neo4j Graph Data Science @@ -107,7 +107,7 @@ +