Skip to content

Conversation

@recrwplay
Copy link
Collaborator

No description provided.

@recrwplay recrwplay requested a review from lidiazuin April 10, 2024 08:18
@netlify
Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for neo4j-docs-ui ready!

Name Link
🔨 Latest commit 177521d
🔍 Latest deploy log https://app.netlify.com/sites/neo4j-docs-ui/deploys/6686803215ba5b0008b2fef2
😎 Deploy Preview https://deploy-preview-223--neo4j-docs-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

. *Working with data sets*
+
Learn stuff
. *Step 3 goes here*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: with these changes, now every time we use . it will turn into the blue circled number?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's using a role that is applied to the whole list, in this case [.next-steps], so only lists with that role would have the styles applied.

Also, the css styles for this role are only applied when the page-layout attribute is set to docs-ndl, which we will use for all the new index pages. If we want to use this style of list anywhere else we could remove that requirement.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I missed the [.next-steps] line. I was wondering if that could be helpful for tutorial pages at some point, but we can revisit that later. Thanks for explaining!

Copy link
Collaborator Author

@recrwplay recrwplay Apr 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this could become a reusable pattern that we can apply to existing docs - tutorials are a good example

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are missing the feedback widget. I guess we can use the same style, just update with NDL colors?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've restored the feedback widget - it disabled it at some point in the pages while developing

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add rounded corners to embedded videos? I found this code to be added in the custom CSS:

.video-player .plyr video { object-fit: cover !important; border-radius: 10px !important; }

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a border-radius to display slightly rounded corners

margin-left: 5rem;
}

body.docs-ndl.color-docs .cards .sect2 h3,
Copy link
Collaborator

@lidiazuin lidiazuin Jun 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 412, could we have something like this for the icons to be aligned to the left of the text? I suppose this is for the list widget that is being used in the Tutorials subpage?

body.docs-ndl .lists .sect2 .icon img,
body.docs-ndl .icon-s .sect2 .icon img {
  width: 3rem;
  height: 3rem;
  padding: 0;
  margin: 40px;
  float: left
}

@recrwplay recrwplay merged commit fcad080 into master Jul 5, 2024
recrwplay added a commit to recrwplay/docs-ui that referenced this pull request Jul 22, 2024
@recrwplay recrwplay deleted the docs-ndl branch November 27, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants