From 3d6a7d4d65707cc581f152b4e59f6d2a060d8d80 Mon Sep 17 00:00:00 2001 From: Neil Dewhurst Date: Tue, 11 Mar 2025 15:44:23 +0000 Subject: [PATCH 1/4] add card-link and banner-link class for tracking --- src/js/70-docs-ndl.js | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/js/70-docs-ndl.js b/src/js/70-docs-ndl.js index da6f6f0a..9d427ceb 100644 --- a/src/js/70-docs-ndl.js +++ b/src/js/70-docs-ndl.js @@ -7,6 +7,11 @@ document.addEventListener('DOMContentLoaded', function () { } } + // add a class to the banner link for tracking + document.querySelectorAll('.banner a').forEach(function (a) { + a.classList.add('banner-link') + }) + // if a card is 'selectable' then make it a click target // by taking the link from the card and wrapping the whole card in an anchor tag with that link // if the card contains more than one link, the first link is used @@ -17,7 +22,7 @@ document.addEventListener('DOMContentLoaded', function () { var target = link.querySelector('a').getAttribute('href') var card = link.parentElement card.classList.add('selectable') - const cardLink = createElement('a', 'link') + const cardLink = createElement('a', 'link card-link') cardLink.setAttribute('href', target) moveElements(card, cardLink) card.appendChild(cardLink) @@ -25,6 +30,11 @@ document.addEventListener('DOMContentLoaded', function () { e.preventDefault() window.location.href = target }) + + // add a class to the link itself for tracking + link.querySelectorAll('a').forEach(function (a) { + a.classList.add('card-link') + }) }) } From e515aec7ff7106ac5c077baea1e3850b1b4e34ea Mon Sep 17 00:00:00 2001 From: Neil Dewhurst Date: Tue, 11 Mar 2025 15:55:13 +0000 Subject: [PATCH 2/4] add class to links on all cards --- src/js/70-docs-ndl.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/js/70-docs-ndl.js b/src/js/70-docs-ndl.js index 9d427ceb..29bbc399 100644 --- a/src/js/70-docs-ndl.js +++ b/src/js/70-docs-ndl.js @@ -12,6 +12,11 @@ document.addEventListener('DOMContentLoaded', function () { a.classList.add('banner-link') }) + // add a class to the link itself for tracking + document.querySelectorAll('.cards .link a').forEach(function (a) { + a.classList.add('card-link') + }) + // if a card is 'selectable' then make it a click target // by taking the link from the card and wrapping the whole card in an anchor tag with that link // if the card contains more than one link, the first link is used @@ -30,11 +35,6 @@ document.addEventListener('DOMContentLoaded', function () { e.preventDefault() window.location.href = target }) - - // add a class to the link itself for tracking - link.querySelectorAll('a').forEach(function (a) { - a.classList.add('card-link') - }) }) } From 88181a8d550e36dfb646492fc17f42d1a62c103d Mon Sep 17 00:00:00 2001 From: Neil Dewhurst Date: Tue, 11 Mar 2025 16:09:00 +0000 Subject: [PATCH 3/4] fix banner button styles --- src/css/themes.css | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/css/themes.css b/src/css/themes.css index 046862f9..403b374f 100644 --- a/src/css/themes.css +++ b/src/css/themes.css @@ -131,12 +131,12 @@ body.docs .navbar .navbar-item.getting-started-cta .navbar-link:active { body.docs .banner .button .banner-link { background: var(--banner-background-color); - color: var(--banner-text-color); + /* color: var(--banner-text-color); */ } -body.docs .banner .button .banner-link:hover { +/* body.docs .banner .button .banner-link:hover { background: rgba(var(--banner-hover-color)); -} +} */ body.docs .banner .button .banner-link:active { background: rgba(var(--banner-background-color)); From 1c76060897fb334c8fc1767212fcc2075ff6664d Mon Sep 17 00:00:00 2001 From: Neil Dewhurst Date: Tue, 11 Mar 2025 16:11:10 +0000 Subject: [PATCH 4/4] only add class to top cards --- src/js/70-docs-ndl.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/js/70-docs-ndl.js b/src/js/70-docs-ndl.js index 29bbc399..da636112 100644 --- a/src/js/70-docs-ndl.js +++ b/src/js/70-docs-ndl.js @@ -13,7 +13,7 @@ document.addEventListener('DOMContentLoaded', function () { }) // add a class to the link itself for tracking - document.querySelectorAll('.cards .link a').forEach(function (a) { + document.querySelectorAll('.cards:not(.bottom-cards) .link a').forEach(function (a) { a.classList.add('card-link') })