From c86de066354161f7221ddd9d44859d667ee6a3c3 Mon Sep 17 00:00:00 2001
From: Neil Dewhurst <ndewhurst@gmail.com>
Date: Fri, 11 Apr 2025 16:40:09 +0100
Subject: [PATCH] minor better nav heighting

---
 preview-src/admonitions.adoc |  3 ++-
 preview-src/ui-model.yml     | 30 +++++++++++++++---------------
 src/css/nav.css              |  5 +++--
 src/css/vars.css             |  6 +-----
 src/partials/nav-menu.hbs    |  2 +-
 5 files changed, 22 insertions(+), 24 deletions(-)

diff --git a/preview-src/admonitions.adoc b/preview-src/admonitions.adoc
index 83cce8ca..43091211 100644
--- a/preview-src/admonitions.adoc
+++ b/preview-src/admonitions.adoc
@@ -1,5 +1,6 @@
 = Admonitions
 :check-mark: icon:check[]
+// :page-disablefeedback: true
 
 
 == NOTE
@@ -27,7 +28,7 @@ Eos suscipit scaevola at.
 
 Cum dicat putant ne.
 Est in reque homero principes, meis deleniti mediocrem ad has.
-Altera atomorum his ex, has cu elitr melius propriae.
+// Altera atomorum his ex, has cu elitr melius propriae.
 
 [TIP]
 ====
diff --git a/preview-src/ui-model.yml b/preview-src/ui-model.yml
index a8423926..55fa091c 100644
--- a/preview-src/ui-model.yml
+++ b/preview-src/ui-model.yml
@@ -265,6 +265,21 @@ page:
     - content: GraphGists
       url: graph-gist-index.html
       urlType: internal
+    - content: Star Wars Social Network
+      url: graph-gist-star-wars-social-network.html
+      urlType: internal
+    - content: First Steps with Cypher
+      url: first-steps-with-cypher.html
+      urlType: internal
+    - content: Category Pop Culture
+      url: graph-gist-category-pop-culture.html
+      urlType: internal
+    - content: Contribute
+      url: contribute.html
+      urlType: internal
+    - content: Promos
+      url: promos.html
+      urlType: internal
     - content: Reference - a long title that also has child pages
       items:
       - content: Keyboard Shortcuts
@@ -283,21 +298,6 @@ page:
           - content: English + 中文
             url: '/xyz/4.1/index.html#english+中文'
             urlType: internal
-    - content: Star Wars Social Network
-      url: graph-gist-star-wars-social-network.html
-      urlType: internal
-    - content: First Steps with Cypher
-      url: first-steps-with-cypher.html
-      urlType: internal
-    - content: Category Pop Culture
-      url: graph-gist-category-pop-culture.html
-      urlType: internal
-    - content: Contribute
-      url: contribute.html
-      urlType: internal
-    - content: Promos
-      url: promos.html
-      urlType: internal
   # additional page attributes indexed by page-slug
     pages-data:
       cheatsheet-products: &cheatsheet-products
diff --git a/src/css/nav.css b/src/css/nav.css
index 2fae8d17..c9feea0b 100644
--- a/src/css/nav.css
+++ b/src/css/nav.css
@@ -157,8 +157,9 @@ html.is-clipped--nav {
   position: relative;
 }
 
-.nav-panel-manu.has-feedback .nav-menu {
-  margin-bottom: calc(var(--feedback-height) + 1rem);
+.nav-panel-menu.has-feedback {
+  height: calc(var(--nav-panel-height--desktop) - var(--feedback-height) - 1.5rem);
+  padding-bottom: calc(var(--feedback-height) * 1.5);
 }
 
 .nav-menu .component-title {
diff --git a/src/css/vars.css b/src/css/vars.css
index 29c61b31..9264b532 100644
--- a/src/css/vars.css
+++ b/src/css/vars.css
@@ -406,11 +406,7 @@
   --nav-height: calc(var(--body-min-height) - var(--toolbar-height));
   --nav-height--desktop: var(--body-min-height);
   --nav-panel-height: calc(var(--nav-height) - var(--drawer-height));
-  --nav-panel-height--desktop:
-    calc(
-      var(--nav-height--desktop) - var(--drawer-height) - var(--feedback-height) * 8px
-    );  /* 1rem is feedback padding */
-
+  --nav-panel-height--desktop: calc(var(--nav-height--desktop) - var(--drawer-height));
   --nav-width: 18rem;
   --toc-top: calc(var(--body-top) + var(--toolbar-height));
   --kb-metadata-top: calc(var(--body-top) + var(--toolbar-height));
diff --git a/src/partials/nav-menu.hbs b/src/partials/nav-menu.hbs
index 61f60b8a..0e532adc 100644
--- a/src/partials/nav-menu.hbs
+++ b/src/partials/nav-menu.hbs
@@ -6,7 +6,7 @@
   </div>
 </aside>
 {{else}}
-<div class="nav-panel-menu is-active" data-panel="menu">
+<div class="nav-panel-menu is-active{{#unless page.attributes.disablefeedback}} has-feedback{{/unless}}" data-panel="menu">
     <nav class="nav-menu">
     {{#with page.navigation}}{{> nav-tree navigation=this module=@root.page.module}}{{/with}}
   </nav>