Reviewing Queries and aggregations section #12
Conversation
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
… of the queries and aggregations pages
mjfwebb
left a comment
mjfwebb
left a comment
There was a problem hiding this comment.
Just one small consideration, otherwise looks great!
|
|
||
| When performing an aggregation on related nodes, the query against the relationship | ||
| can be defined as an xref::queries-aggregations/queries.adoc#_undirected_queries[undirected] using the argument `directed: false`: | ||
| can be defined as "undirect" by using the argument `directed: false`: |
There was a problem hiding this comment.
I think as an adjective it would make more sense to use "undirected", as we would otherwise call it "directed" rather than "direct".
| When performing an aggregation on related nodes, the query against the relationship | ||
| can be defined as "undirect" by using the argument `directed: false`: | ||
| can be defined as "directed" by using the argument `directed: false`: |
There was a problem hiding this comment.
yep sorry, I was just fixing that as you commented haha
| ---- | ||
|
|
||
| > The nature of RegEx matching means that on an unprotected API, this could potentially be used to execute a ReDoS attack (https://owasp.org/www-community/attacks/Regular_expression_Denial_of_Service_-_ReDoS) against the backing Neo4j database. | ||
| // This next section seems to be wrong. It mentions 4 operators, but there's one 2 and a similar sentence is repicated with not much context. Please take a look. |
There was a problem hiding this comment.
@mjfwebb did you have the chance to check this? I merged the PR and just remembered I left this note
| | Used in the case of `DateTime`, `LocalDateTime`, `LocalTime`, `Time`, and `Duration`. | ||
| | `_MIN_EQUAL`, `_MIN_GT`, `_MIN_GTE`, `_MIN_LT`, `_MIN_LTE`, `_MAX_EQUAL`, `_MAX_GT`, `_MAX_GTE`, `_MAX_LT`, `_MAX_LTE` | ||
| a| | ||
| [source, graphql, indent=0] |
There was a problem hiding this comment.
Could you please provide an example here? @mjfwebb
There was a problem hiding this comment.
Types:
type Event {
title: String!
startTime: DateTime!
}
Query:
query EventsAggregate {
users(where: { eventsAggregate: { node: { startTime_GT: "2022-08-14T15:00:00Z" } } }) {
name
}
}
| | Description. | ||
| | `_AVERAGE_EQUAL`, `_AVERAGE_GT`, `_AVERAGE_GTE`, `_AVERAGE_LT`, `_AVERAGE_LTE` | ||
| a| | ||
| [source, graphql, indent=0] |
There was a problem hiding this comment.
Types:
type Event {
title: String!
duration: Duration!
}
Query:
query EventsAggregate {
users(where: { eventsAggregate: { node: { duration_AVERAGE_LT: "PT2H" } } }) {
name
}
}
3 participants
No description provided.