Adding clarification that sub-admin roles should not be able to change their own privileges #1440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e their own privileges
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
Hunterness
reviewed
Feb 27, 2024
|
@phil198, Which version should this go into, 5.18 or current? |
current please @renetapopova |
renetapopova
pushed a commit
to renetapopova/docs-operations
that referenced
this pull request
Feb 27, 2024
…e their own privileges (neo4j#1440) This was noticed in a recent internal pentest of RBAC. We need to clarify that it is necessary to explicitly deny the ability to change your own privileges if you copy the admin role (otherwise the new role is essentially unconstrained).
renetapopova
pushed a commit
to renetapopova/docs-operations
that referenced
this pull request
Feb 27, 2024
…e their own privileges (neo4j#1440) This was noticed in a recent internal pentest of RBAC. We need to clarify that it is necessary to explicitly deny the ability to change your own privileges if you copy the admin role (otherwise the new role is essentially unconstrained).
renetapopova
added
cherry-pick-this-to-4.4
cherry-pick-this-to-5.x
and removed
cherry-pick-this-backward
labels
renetapopova
added a commit
that referenced
this pull request
Feb 28, 2024
…e their own privileges (#1451) Cherry-picked from #1440 This was noticed in a recent internal pentest of RBAC. We need to clarify that it is necessary to explicitly deny the ability to change your own privileges if you copy the admin role (otherwise the new role is essentially unconstrained). Co-authored-by: Phil Wright <95368282+phil198@users.noreply.github.com>
renetapopova
added a commit
that referenced
this pull request
Feb 29, 2024
…e their own privileges (#1450) Cherry-picked from #1440 This was noticed in a recent internal pentest of RBAC. We need to clarify that it is necessary to explicitly deny the ability to change your own privileges if you copy the admin role (otherwise the new role is essentially unconstrained). Co-authored-by: Phil Wright <95368282+phil198@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was noticed in a recent internal pentest of RBAC.
We need to clarify that it is necessary to explicitly deny the ability to change your own privileges if you copy the admin role (otherwise the new role is essentially unconstrained).