Discovery service V1 to V2 upgrading guide #1739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #1731 |
|
Thank you, @renetapopova! Well done! I think the page looks very good now. I have a question about the page 'Settings reference'. We have to update the list of settings there. Should we do it within this PR or open a new one? |
yirensum
commented
Jul 30, 2024
yirensum
changed the title
Co-authored-by: NataliaIvakina <82437520+NataliaIvakina@users.noreply.github.com>
Co-authored-by: NataliaIvakina <82437520+NataliaIvakina@users.noreply.github.com>
Co-authored-by: NataliaIvakina <82437520+NataliaIvakina@users.noreply.github.com>
Co-authored-by: NataliaIvakina <82437520+NataliaIvakina@users.noreply.github.com>
Co-authored-by: NataliaIvakina <82437520+NataliaIvakina@users.noreply.github.com>
Co-authored-by: Nick Giles <100630647+nick-giles-neo@users.noreply.github.com>
Co-authored-by: Nick Giles <100630647+nick-giles-neo@users.noreply.github.com>
renetapopova
force-pushed
the
feature/lighthouse-updates
branch
from
2f596e0 to
5b07d3d
Compare
|
@yirensum, @nick-giles-neo, and @NataliaIvakina, I think this is ready to be merged unless you have some final comments. |
yirensum
commented
Aug 2, 2024
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
|
Hey @yirensum, could you please take a final look? |
NataliaIvakina
approved these changes
Aug 5, 2024
|
This looks good, going through some testing now, will raise a new PR of some minor improvements |
NataliaIvakina
added a commit
to NataliaIvakina/docs-operations
that referenced
this pull request
Aug 22, 2024
I've added v2 for discovery setup. This is very similar to v1 found in https://neo4j.com/docs/operations-manual/current/clustering/setup/discovery/, with the exception that the settings names have been changed, and example removed. --------- Co-authored-by: sumyiren <sumyiren@gmail.com> Co-authored-by: Reneta Popova <reneta.popova@neo4j.com> Co-authored-by: NataliaIvakina <82437520+NataliaIvakina@users.noreply.github.com> Co-authored-by: Nick Giles <100630647+nick-giles-neo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added v2 for discovery setup. This is very similar to v1 found in https://neo4j.com/docs/operations-manual/current/clustering/setup/discovery/, with the exception that the settings names have been changed, and example removed.