Lighthouse - minor improvements #1756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renetapopova
reviewed
Aug 6, 2024
There was a problem hiding this comment.
Thanks, @sumyiren. Overall, it looks very good. I added some editorial suggestions, and I might have also missed some 😄.
Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
|
Thanks @renetapopova for the thorough review! I've committed them all now |
nick-giles-neo
approved these changes
Aug 6, 2024
Co-authored-by: Nick Giles <100630647+nick-giles-neo@users.noreply.github.com>
renetapopova
reviewed
Aug 6, 2024
Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
Much thanks! |
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
renetapopova
approved these changes
Aug 7, 2024
NataliaIvakina
pushed a commit
to NataliaIvakina/docs-operations
that referenced
this pull request
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After running through the guide myself, I've proposed a few improvements to help ensure that the user does not get muddled up when doing the migration.
Sorry for raising so many changes once again, but hopefully once done well, it'll avoid support cases in the future
A side note, new server rolling is the hardest to do. Procedures is the easiest. In-place rolling is pretty ok, but will require loss of fault tolerance.