Skip to content

Conversation

@stefgia
Copy link
Contributor

@stefgia stefgia commented Sep 2, 2024

https://trello.com/c/MgmtbjRJ/1470-support-docker-secrets

  • Adds documentation for general docker compose usage
  • Adds documentation for using secrets with neo4j

Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @stefgia. I added some suggestions to make it a bit consistent in terms of style with the other docker compose tutorial. I haven't built it locally to see how they look. There might be some formatting issues. If you like my suggestions, I am happy to add them myself and assign you as a reviewer. There is also an option to use tab examples for the two ways of authentication instead of two separate sections. I am happy to play with this as well. Let me know what you think.
Thanks for the great content, btw!

@renetapopova renetapopova self-requested a review September 5, 2024 11:17
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @stefgia, I have pushed an editorial update of the page. Could you please take a look to see if you're happy with it? I've also tested the steps, and they work as expected.

@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Sep 5, 2024

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@renetapopova renetapopova merged commit 4e23452 into dev Sep 6, 2024
@renetapopova renetapopova deleted the stef/add-docker-compose-documentation branch September 6, 2024 10:57
renetapopova added a commit to renetapopova/docs-operations that referenced this pull request Sep 26, 2024
https://trello.com/c/MgmtbjRJ/1470-support-docker-secrets

* Adds documentation for general docker compose usage
* Adds documentation for using secrets with neo4j

---------

Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
renetapopova added a commit to renetapopova/docs-operations that referenced this pull request Oct 25, 2024
https://trello.com/c/MgmtbjRJ/1470-support-docker-secrets

* Adds documentation for general docker compose usage
* Adds documentation for using secrets with neo4j

---------

Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
renetapopova added a commit that referenced this pull request Oct 28, 2024
https://trello.com/c/MgmtbjRJ/1470-support-docker-secrets

* Adds documentation for general docker compose usage
* Adds documentation for using secrets with neo4j

---------

Cherry-picked from #1804 

* Add documentation for persistent volumes as in 5.x
* Add documentation for plugins as in 5.x

---------

Co-authored-by: Stefanos Giagkiozis <SteveGiagkiozis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants