Skip to content

Conversation

@renetapopova
Copy link
Collaborator

No description provided.

@NataliaIvakina NataliaIvakina self-assigned this Aug 5, 2024
@renetapopova renetapopova mentioned this pull request Aug 15, 2024
@renetapopova renetapopova changed the title Diagnostic info Notification frameworks Aug 15, 2024
@renetapopova renetapopova requested a review from Lojjs August 16, 2024 11:05
@renetapopova renetapopova marked this pull request as ready for review August 16, 2024 11:06
renetapopova and others added 5 commits August 16, 2024 14:04
Co-authored-by: Louise Berglund <louise.berglund@neo4j.com>
Co-authored-by: Louise Berglund <louise.berglund@neo4j.com>
Co-authored-by: Louise Berglund <louise.berglund@neo4j.com>
Co-authored-by: Louise Berglund <louise.berglund@neo4j.com>
@renetapopova renetapopova requested a review from Lojjs August 16, 2024 16:57
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is shaping up nicely, just a few more comment

The GqlStatusObject API provides information about the status of a Cypher query or command execution in compliance with the GQL standard.

The notification object, which is part of the result summary, consists of the following fields:
This page describes both the Neo4j Notification and the GQL-status object frameworks, how they are structured, the objects they provide for notifications, and how to interpret them.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are still not fully consistent on naming. Should we stick to GqlStatusObject (this is what it is called in the codebase) when we talk about the framework/API and GQL-status object (this is what it is called in GQL standard) if we talk about the actual object a user get back or what do you think? Can you read through and check that it is consistent?

NataliaIvakina and others added 2 commits August 20, 2024 10:04
NataliaIvakina and others added 2 commits August 20, 2024 10:54
Co-authored-by: Louise Berglund <louise.berglund@neo4j.com>
@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Aug 20, 2024

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@NataliaIvakina NataliaIvakina merged commit 4c0c4e6 into neo4j:gql-notifications Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants