Arrow export multiple properties #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DarthMax
commented
May 17, 2022
DarthMax
commented
- Add support for exporting node properties via arrow
- Add support for exporting relationship properties via arrow
- introduce flag to toggle between formats
- introduce flag to toggle between formats
adamnsch
suggested changes
May 17, 2022
Contributor
adamnsch
left a comment
adamnsch
left a comment
There was a problem hiding this comment.
Looks great, mainly concerned about breaking the API and the new dependency. I think we said we will change what format is default when we decide to release 2.0 of the client?
- rename flag from `old_format` to `merge_property_columns`
adamnsch
reviewed
May 17, 2022
Contributor
adamnsch
left a comment
adamnsch
left a comment
There was a problem hiding this comment.
Nice, but I think we got a little mixed up with the name suggestion for the format option
Co-Authored-By: Adam Schill Collberg <adam.schill.collberg@protonmail.com>
DarthMax
force-pushed
the
arrow_export_multiple_properties
branch
from
0489903 to
650d755
Compare
DarthMax
force-pushed
the
arrow_export_multiple_properties
branch
from
6f06b2f to
0dd74fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.