Update math operations to new translation layer #6774
Merged
+258
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
angrykoala
force-pushed
the
fix-tests-update
branch
from
5bd9ba7 to
76ba380
Compare
angrykoala
force-pushed
the
fix-tests-update
branch
from
76ba380 to
4979c75
Compare
a-alle
requested changes
Oct 29, 2025
packages/graphql/src/translate/queryAST/factory/Operations/DeleteFactory.ts
Show resolved
Hide resolved
| ...mutationSubqueries.map((sq) => | ||
| Cypher.utils.concat(new Cypher.With(nestedContext.target), new Cypher.Call(sq, [nestedContext.target])) | ||
| ) | ||
| ...mutationSubqueries.map((sq) => Cypher.utils.concat(new Cypher.With("*"), new Cypher.Call(sq, "*"))) |
There was a problem hiding this comment.
is the "*" instead of nestedContext.target on purpose?
There was a problem hiding this comment.
Yes, we need both, the target and the relationship, we can probably refine it further once all the tests are working
packages/graphql/src/translate/queryAST/factory/Operations/UpdateFactory.ts
Outdated
Show resolved
Hide resolved
a-alle
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.