Skip to content

Delete Mutation #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danstarns merged 11 commits into from
Nov 17, 2020
Merged

Delete Mutation #8

danstarns merged 11 commits into from
Nov 17, 2020

Conversation

@danstarns
Copy link
Contributor

@danstarns danstarns commented Nov 2, 2020

Covers card I decided to not include the option to DETACH and this mutation always calls DETACH. This Branch is merged, conflicting with, this PR it will become 'Non Draft' once this PR is merged.

mutation {
  deleteMovies(where: {id: "123"}) {
    nodesDeleted
  }
}

@danstarns danstarns changed the title Delete mutation Delete Mutation Nov 2, 2020
@danstarns danstarns marked this pull request as ready for review November 16, 2020 12:01
@danstarns danstarns requested a review from oskarhane November 16, 2020 12:01
oskarhane
oskarhane reviewed Nov 17, 2020
View reviewed changes
Copy link
Member

@oskarhane oskarhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Just a few comments, I especially want tests around the negative path, where nothing is found.

packages/graphql/tests/tck/tck-test-files/schema-generation.md
Comment on lines +24 to +27
type DeleteInfo {
nodesDeleted: Int!
relationshipsDeleted: Int!
}
Copy link
Member

@oskarhane oskarhane Nov 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

oskarhane
oskarhane approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@oskarhane oskarhane left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🐧

@danstarns danstarns merged commit e2ba573 into neo4j:master Nov 17, 2020
@danstarns danstarns deleted the delete-mutation branch November 17, 2020 08:33
@renovate renovate bot mentioned this pull request Mar 4, 2025
Merged
1 task
@renovate renovate bot mentioned this pull request Nov 25, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oskarhane oskarhane oskarhane approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danstarns @oskarhane