From 91da240f6a28e6d2832fde444ad833601d1fabc9 Mon Sep 17 00:00:00 2001 From: Rouven Bauer Date: Thu, 18 Aug 2022 09:51:03 +0200 Subject: [PATCH 1/2] Fix unit tests for temporal type serialization --- .../codec/hydration/v2/test_temporal_dehydration.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/unit/common/codec/hydration/v2/test_temporal_dehydration.py b/tests/unit/common/codec/hydration/v2/test_temporal_dehydration.py index 27d5f3d67..f7fcc9faa 100644 --- a/tests/unit/common/codec/hydration/v2/test_temporal_dehydration.py +++ b/tests/unit/common/codec/hydration/v2/test_temporal_dehydration.py @@ -60,15 +60,15 @@ def test_native_date_time_negative_offset(self, hydration_scope): assert struct == Structure(b"I", 1539347861, 474716000, -3600) def test_date_time_zone_id(self, hydration_scope): - dt = DateTime(2018, 10, 12, 11, 37, 41, 474716862, - pytz.timezone("Europe/Stockholm")) + dt = DateTime(2018, 10, 12, 11, 37, 41, 474716862) + dt = pytz.timezone("Europe/Stockholm").localize(dt) struct = hydration_scope.dehydration_hooks[type(dt)](dt) - assert struct == Structure(b"i", 1539339941, 474716862, + assert struct == Structure(b"i", 1539337061, 474716862, "Europe/Stockholm") def test_native_date_time_zone_id(self, hydration_scope): - dt = datetime.datetime(2018, 10, 12, 11, 37, 41, 474716, - pytz.timezone("Europe/Stockholm")) + dt = datetime.datetime(2018, 10, 12, 11, 37, 41, 474716) + dt = pytz.timezone("Europe/Stockholm").localize(dt) struct = hydration_scope.dehydration_hooks[type(dt)](dt) - assert struct == Structure(b"i", 1539339941, 474716000, + assert struct == Structure(b"i", 1539337061, 474716000, "Europe/Stockholm") From 0206d71c17cbbfa426b63092c835310301a6f86e Mon Sep 17 00:00:00 2001 From: Rouven Bauer Date: Thu, 18 Aug 2022 13:27:39 +0200 Subject: [PATCH 2/2] Document expected timezone of Stockholm in tests --- .../unit/common/codec/hydration/v2/test_temporal_dehydration.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/unit/common/codec/hydration/v2/test_temporal_dehydration.py b/tests/unit/common/codec/hydration/v2/test_temporal_dehydration.py index f7fcc9faa..97074e3c7 100644 --- a/tests/unit/common/codec/hydration/v2/test_temporal_dehydration.py +++ b/tests/unit/common/codec/hydration/v2/test_temporal_dehydration.py @@ -62,6 +62,7 @@ def test_native_date_time_negative_offset(self, hydration_scope): def test_date_time_zone_id(self, hydration_scope): dt = DateTime(2018, 10, 12, 11, 37, 41, 474716862) dt = pytz.timezone("Europe/Stockholm").localize(dt) + # offset should be UTC+2 (7200 seconds) struct = hydration_scope.dehydration_hooks[type(dt)](dt) assert struct == Structure(b"i", 1539337061, 474716862, "Europe/Stockholm") @@ -69,6 +70,7 @@ def test_date_time_zone_id(self, hydration_scope): def test_native_date_time_zone_id(self, hydration_scope): dt = datetime.datetime(2018, 10, 12, 11, 37, 41, 474716) dt = pytz.timezone("Europe/Stockholm").localize(dt) + # offset should be UTC+2 (7200 seconds) struct = hydration_scope.dehydration_hooks[type(dt)](dt) assert struct == Structure(b"i", 1539337061, 474716000, "Europe/Stockholm")