From 4c48c7149c46aedac52e4cdc5785375a8e225044 Mon Sep 17 00:00:00 2001 From: Alistair Jones Date: Thu, 14 Jul 2016 11:03:29 +0200 Subject: [PATCH] Remove unnecessary type parameter. --- .../org/neo4j/coreedge/raft/replication/RaftReplicator.java | 6 ++---- .../org/neo4j/coreedge/raft/replication/Replicator.java | 4 ++-- .../neo4j/coreedge/raft/replication/DirectReplicator.java | 6 +++--- .../raft/replication/token/ReplicatedTokenHolderTest.java | 6 +++--- 4 files changed, 10 insertions(+), 12 deletions(-) diff --git a/enterprise/core-edge/src/main/java/org/neo4j/coreedge/raft/replication/RaftReplicator.java b/enterprise/core-edge/src/main/java/org/neo4j/coreedge/raft/replication/RaftReplicator.java index 22857bd89b13..e7344223fd19 100644 --- a/enterprise/core-edge/src/main/java/org/neo4j/coreedge/raft/replication/RaftReplicator.java +++ b/enterprise/core-edge/src/main/java/org/neo4j/coreedge/raft/replication/RaftReplicator.java @@ -35,7 +35,7 @@ /** * A replicator implementation suitable in a RAFT context. Will handle resending due to timeouts and leader switches. */ -public class RaftReplicator implements Replicator, Listener +public class RaftReplicator implements Replicator, Listener { private final CoreMember me; private final Outbound outbound; @@ -90,9 +90,7 @@ public Future replicate( ReplicatedContent command, boolean trackResult } } while( !progress.isReplicated() ); - BiConsumer cleanup = ( ignored1, ignored2 ) -> { - sessionPool.releaseSession( session ); - }; + BiConsumer cleanup = ( ignored1, ignored2 ) -> sessionPool.releaseSession( session ); if( trackResult ) { diff --git a/enterprise/core-edge/src/main/java/org/neo4j/coreedge/raft/replication/Replicator.java b/enterprise/core-edge/src/main/java/org/neo4j/coreedge/raft/replication/Replicator.java index 32cb113d7d7a..f21c8fab782f 100644 --- a/enterprise/core-edge/src/main/java/org/neo4j/coreedge/raft/replication/Replicator.java +++ b/enterprise/core-edge/src/main/java/org/neo4j/coreedge/raft/replication/Replicator.java @@ -24,7 +24,7 @@ /** * Replicate content across a cluster of servers. */ -public interface Replicator +public interface Replicator { /** * Submit content for replication. This method does not guarantee that the content @@ -36,5 +36,5 @@ public interface Replicator * * @return A future that will receive the result when available. Only valid if trackResult is set. */ - Future replicate( CONTENT content, boolean trackResult ) throws InterruptedException; + Future replicate( ReplicatedContent content, boolean trackResult ) throws InterruptedException; } diff --git a/enterprise/core-edge/src/test/java/org/neo4j/coreedge/raft/replication/DirectReplicator.java b/enterprise/core-edge/src/test/java/org/neo4j/coreedge/raft/replication/DirectReplicator.java index d2b190ba1e24..0240d3f3ccc7 100644 --- a/enterprise/core-edge/src/test/java/org/neo4j/coreedge/raft/replication/DirectReplicator.java +++ b/enterprise/core-edge/src/test/java/org/neo4j/coreedge/raft/replication/DirectReplicator.java @@ -25,7 +25,7 @@ import org.neo4j.coreedge.raft.state.StateMachine; -public class DirectReplicator implements Replicator +public class DirectReplicator implements Replicator { private final StateMachine stateMachine; private long commandIndex = 0; @@ -36,10 +36,10 @@ public DirectReplicator( StateMachine stateMachine ) } @Override - public synchronized Future replicate( Command content, boolean trackResult ) + public synchronized Future replicate( ReplicatedContent content, boolean trackResult ) { AtomicReference> futureResult = new AtomicReference<>( new CompletableFuture<>() ); - stateMachine.applyCommand( content, commandIndex++, result -> { + stateMachine.applyCommand( (Command) content, commandIndex++, result -> { if ( trackResult ) { futureResult.getAndUpdate( result::apply ); diff --git a/enterprise/core-edge/src/test/java/org/neo4j/coreedge/raft/replication/token/ReplicatedTokenHolderTest.java b/enterprise/core-edge/src/test/java/org/neo4j/coreedge/raft/replication/token/ReplicatedTokenHolderTest.java index a70c370be339..4027cf295cd3 100644 --- a/enterprise/core-edge/src/test/java/org/neo4j/coreedge/raft/replication/token/ReplicatedTokenHolderTest.java +++ b/enterprise/core-edge/src/test/java/org/neo4j/coreedge/raft/replication/token/ReplicatedTokenHolderTest.java @@ -59,8 +59,8 @@ public class ReplicatedTokenHolderTest { - Dependencies dependencies = mock( Dependencies.class ); - long TIMEOUT_MILLIS = 10; + private Dependencies dependencies = mock( Dependencies.class ); + private long TIMEOUT_MILLIS = 10; @Test public void shouldStoreInitialTokens() throws Exception @@ -156,7 +156,7 @@ public void shouldTimeoutIfTokenDoesNotReplicateWithinTimeout() throws Exception } } - private static class DropAllTheThingsReplicator implements Replicator + private static class DropAllTheThingsReplicator implements Replicator { @Override public Future replicate( final ReplicatedContent content, boolean trackResult )