diff --git a/community/ssl/src/main/java/org/neo4j/ssl/HostnameVerificationEngineModification.java b/community/ssl/src/main/java/org/neo4j/ssl/ClientSideHostnameVerificationEngineModification.java similarity index 91% rename from community/ssl/src/main/java/org/neo4j/ssl/HostnameVerificationEngineModification.java rename to community/ssl/src/main/java/org/neo4j/ssl/ClientSideHostnameVerificationEngineModification.java index 4bc09f54d01ad..5a06797ff0602 100644 --- a/community/ssl/src/main/java/org/neo4j/ssl/HostnameVerificationEngineModification.java +++ b/community/ssl/src/main/java/org/neo4j/ssl/ClientSideHostnameVerificationEngineModification.java @@ -23,7 +23,10 @@ import javax.net.ssl.SSLEngine; import javax.net.ssl.SSLParameters; -public class HostnameVerificationEngineModification implements Function +/** + * Client side modifier for SSLEngine to mandate hostname verification + */ +public class ClientSideHostnameVerificationEngineModification implements Function { /** * Apply modifications to engine to enable hostname verification (client side only) diff --git a/community/ssl/src/main/java/org/neo4j/ssl/OnConnectSslHandler.java b/community/ssl/src/main/java/org/neo4j/ssl/ClientSideOnConnectSslHandler.java similarity index 94% rename from community/ssl/src/main/java/org/neo4j/ssl/OnConnectSslHandler.java rename to community/ssl/src/main/java/org/neo4j/ssl/ClientSideOnConnectSslHandler.java index 177f65b0d9227..cf025b9c5dcca 100644 --- a/community/ssl/src/main/java/org/neo4j/ssl/OnConnectSslHandler.java +++ b/community/ssl/src/main/java/org/neo4j/ssl/ClientSideOnConnectSslHandler.java @@ -37,22 +37,22 @@ import java.util.function.Function; import javax.net.ssl.SSLEngine; -public class OnConnectSslHandler extends ChannelDuplexHandler +public class ClientSideOnConnectSslHandler extends ChannelDuplexHandler { private final ChannelPipeline pipeline; private final SslContext sslContext; private final Collection> engineModifications; - OnConnectSslHandler( Channel channel, SslContext sslContext, boolean isClient, boolean verifyHostname, String[] tlsVersions ) + ClientSideOnConnectSslHandler( Channel channel, SslContext sslContext, boolean verifyHostname, String[] tlsVersions ) { this.pipeline = channel.pipeline(); this.sslContext = sslContext; this.engineModifications = new ArrayList<>(); - engineModifications.add( new EssentialEngineModifications( tlsVersions, isClient ) ); + engineModifications.add( new EssentialEngineModifications( tlsVersions, true ) ); if ( verifyHostname ) { - engineModifications.add( new HostnameVerificationEngineModification() ); + engineModifications.add( new ClientSideHostnameVerificationEngineModification() ); } } diff --git a/community/ssl/src/main/java/org/neo4j/ssl/SslPolicy.java b/community/ssl/src/main/java/org/neo4j/ssl/SslPolicy.java index f689745428051..bbbaa5acfe0b8 100644 --- a/community/ssl/src/main/java/org/neo4j/ssl/SslPolicy.java +++ b/community/ssl/src/main/java/org/neo4j/ssl/SslPolicy.java @@ -35,7 +35,6 @@ import javax.net.ssl.SSLEngine; import javax.net.ssl.SSLException; import javax.net.ssl.TrustManagerFactory; -import javax.xml.bind.DatatypeConverter; import org.neo4j.logging.Log; import org.neo4j.logging.LogProvider; @@ -55,7 +54,6 @@ public class SslPolicy private final SslProvider sslProvider; private final boolean verifyHostname; - private final LogProvider logProvider; private final Log log; public SslPolicy( PrivateKey privateKey, X509Certificate[] keyCertChain, List tlsVersions, List ciphers, ClientAuth clientAuth, @@ -69,7 +67,6 @@ public SslPolicy( PrivateKey privateKey, X509Certificate[] keyCertChain, List sslHandshakeFuture() @@ -132,13 +131,13 @@ static class Bucket extends SimpleChannelInboundHandler } @Override - protected void channelRead0( ChannelHandlerContext ctx, ByteBuf msg ) throws Exception + protected void channelRead0( ChannelHandlerContext ctx, ByteBuf msg ) { collectedData.writeBytes( msg ); } @Override - public void exceptionCaught( ChannelHandlerContext ctx, Throwable cause ) throws Exception + public void exceptionCaught( ChannelHandlerContext ctx, Throwable cause ) { } } @@ -157,13 +156,13 @@ public class ClientInitializer extends ChannelInitializer } @Override - protected void initChannel( SocketChannel channel ) throws Exception + protected void initChannel( SocketChannel channel ) { ChannelPipeline pipeline = channel.pipeline(); - OnConnectSslHandler onConnectSslHandler = (OnConnectSslHandler) sslPolicy.nettyClientHandler( channel, sslContext ); + ChannelHandler clientOnConnectSslHandler = sslPolicy.nettyClientHandler( channel, sslContext ); - pipeline.addLast( onConnectSslHandler ); + pipeline.addLast( clientOnConnectSslHandler ); pipeline.addLast( new ChannelInboundHandlerAdapter() { @Override