diff --git a/community/security/src/main/java/org/neo4j/commandline/admin/security/UsersCommand.java b/community/security/src/main/java/org/neo4j/commandline/admin/security/UsersCommand.java index df444236bb6f6..428fdfbc23b4f 100644 --- a/community/security/src/main/java/org/neo4j/commandline/admin/security/UsersCommand.java +++ b/community/security/src/main/java/org/neo4j/commandline/admin/security/UsersCommand.java @@ -210,8 +210,8 @@ private static List> settings() private FileUserRepository getUserRepository() throws Throwable { Config config = loadNeo4jConfig( homeDir, configDir ); - Path userStoreFile = BasicAuthManagerFactory.getUserStoreFile( config ); - FileUserRepository userRepository = new FileUserRepository( userStoreFile, NullLogProvider.getInstance() ); + FileUserRepository userRepository = + BasicAuthManagerFactory.getUserRepository( config, NullLogProvider.getInstance() ); userRepository.start(); return userRepository; } diff --git a/community/security/src/main/java/org/neo4j/server/security/auth/BasicAuthManagerFactory.java b/community/security/src/main/java/org/neo4j/server/security/auth/BasicAuthManagerFactory.java index 270cc4cb52842..042d494e5f21e 100644 --- a/community/security/src/main/java/org/neo4j/server/security/auth/BasicAuthManagerFactory.java +++ b/community/security/src/main/java/org/neo4j/server/security/auth/BasicAuthManagerFactory.java @@ -40,7 +40,7 @@ public class BasicAuthManagerFactory extends AuthManager.Factory { private static final String USER_STORE_FILENAME = "auth"; - public static Path getUserStoreFile( Config config ) + public static FileUserRepository getUserRepository( Config config, LogProvider logProvider ) { // Resolve auth store file names File authStoreDir = config.get( DatabaseManagementSystemSettings.auth_store_directory ); @@ -52,7 +52,7 @@ public static Path getUserStoreFile( Config config ) { userStoreFile = new File( authStoreDir, USER_STORE_FILENAME ); } - return userStoreFile.toPath(); + return new FileUserRepository( userStoreFile.toPath(), logProvider ); } public interface Dependencies @@ -75,8 +75,7 @@ public AuthManager newInstance( Config config, LogProvider logProvider ) "configuration setting auth_enabled=false" ); } - final Path userStoreFile = getUserStoreFile( config ); - final UserRepository userRepository = new FileUserRepository( userStoreFile, logProvider ); + final UserRepository userRepository = getUserRepository( config, logProvider ); final PasswordPolicy passwordPolicy = new BasicPasswordPolicy(); diff --git a/enterprise/security/src/main/java/org/neo4j/server/security/enterprise/auth/EnterpriseAuthManagerFactory.java b/enterprise/security/src/main/java/org/neo4j/server/security/enterprise/auth/EnterpriseAuthManagerFactory.java index 1400cee390b8f..575bfc93b1d6d 100644 --- a/enterprise/security/src/main/java/org/neo4j/server/security/enterprise/auth/EnterpriseAuthManagerFactory.java +++ b/enterprise/security/src/main/java/org/neo4j/server/security/enterprise/auth/EnterpriseAuthManagerFactory.java @@ -86,11 +86,9 @@ public AuthManager newInstance( Config config, LogProvider logProvider ) private static InternalFlatFileRealm createInternalRealm( Config config, LogProvider logProvider ) { // Resolve auth store and roles file names - Path userStoreFile = getUserStoreFile( config ); File authStoreDir = config.get( DatabaseManagementSystemSettings.auth_store_directory ); File roleStoreFile = new File( authStoreDir, ROLE_STORE_FILENAME ); - - final UserRepository userRepository = new FileUserRepository( userStoreFile, logProvider ); + final UserRepository userRepository = getUserRepository( config, logProvider ); final RoleRepository roleRepository = new FileRoleRepository( roleStoreFile.toPath(), logProvider );