diff --git a/community/kernel/src/main/java/org/neo4j/kernel/api/security/AuthSubject.java b/community/kernel/src/main/java/org/neo4j/kernel/api/security/AuthSubject.java index 0c31ea5423839..13bf68fd22882 100644 --- a/community/kernel/src/main/java/org/neo4j/kernel/api/security/AuthSubject.java +++ b/community/kernel/src/main/java/org/neo4j/kernel/api/security/AuthSubject.java @@ -41,9 +41,10 @@ public interface AuthSubject extends AccessMode void setPassword( String password, boolean requirePasswordChange ) throws IOException, InvalidArgumentsException; /** - * Changes authentication status to SUCCESS if in PASSWORD_CHANGE_REQUIRED + * Changes the {@link AuthenticationResult} status to {@link AuthenticationResult#SUCCESS SUCCESS} if it was {@link AuthenticationResult#PASSWORD_CHANGE_REQUIRED PASSWORD_CHANGE_REQUIRED}. + * This allows users that changed their password to become authorized for continued processing. */ - void passwordChangeNoLongerRequired(); + void setPasswordChangeNoLongerRequired(); /** * Determines whether this subject is allowed to execute a procedure with the parameter string in its procedure annotation. @@ -98,7 +99,7 @@ public void setPassword( String password, boolean requirePasswordChange ) } @Override - public void passwordChangeNoLongerRequired() + public void setPasswordChangeNoLongerRequired() { } @@ -222,7 +223,7 @@ public void setPassword( String password, boolean requirePasswordChange ) } @Override - public void passwordChangeNoLongerRequired() + public void setPasswordChangeNoLongerRequired() { } diff --git a/community/security/src/main/java/org/neo4j/server/security/auth/AuthProcedures.java b/community/security/src/main/java/org/neo4j/server/security/auth/AuthProcedures.java index 662fd024a329d..23fd6726feeed 100644 --- a/community/security/src/main/java/org/neo4j/server/security/auth/AuthProcedures.java +++ b/community/security/src/main/java/org/neo4j/server/security/auth/AuthProcedures.java @@ -84,7 +84,7 @@ public void changePassword( @Name( "password" ) String password ) throws Invalid throw new AuthorizationViolationException( "Anonymous cannot change password" ); } userManager.setUserPassword( authSubject.username(), password, false ); - authSubject.passwordChangeNoLongerRequired(); + authSubject.setPasswordChangeNoLongerRequired(); } @Description( "Show the current user." ) diff --git a/community/security/src/main/java/org/neo4j/server/security/auth/BasicAuthSubject.java b/community/security/src/main/java/org/neo4j/server/security/auth/BasicAuthSubject.java index 46f6616b8050d..b49a95eec839f 100644 --- a/community/security/src/main/java/org/neo4j/server/security/auth/BasicAuthSubject.java +++ b/community/security/src/main/java/org/neo4j/server/security/auth/BasicAuthSubject.java @@ -94,11 +94,11 @@ public void setPassword( String password, boolean requirePasswordChange ) authManager.setPassword( this, user.name(), password, requirePasswordChange ); // Make user authenticated if successful - passwordChangeNoLongerRequired(); + setPasswordChangeNoLongerRequired(); } @Override - public void passwordChangeNoLongerRequired() + public void setPasswordChangeNoLongerRequired() { if ( authenticationResult == PASSWORD_CHANGE_REQUIRED ) { diff --git a/enterprise/kernel/src/main/java/org/neo4j/kernel/enterprise/api/security/EnterpriseAuthSubject.java b/enterprise/kernel/src/main/java/org/neo4j/kernel/enterprise/api/security/EnterpriseAuthSubject.java index 313fa5f6e7e47..1addc915a26b0 100644 --- a/enterprise/kernel/src/main/java/org/neo4j/kernel/enterprise/api/security/EnterpriseAuthSubject.java +++ b/enterprise/kernel/src/main/java/org/neo4j/kernel/enterprise/api/security/EnterpriseAuthSubject.java @@ -114,7 +114,7 @@ public void setPassword( String password, boolean requirePasswordChange ) } @Override - public void passwordChangeNoLongerRequired() + public void setPasswordChangeNoLongerRequired() { } diff --git a/enterprise/security/src/main/java/org/neo4j/server/security/enterprise/auth/StandardEnterpriseAuthSubject.java b/enterprise/security/src/main/java/org/neo4j/server/security/enterprise/auth/StandardEnterpriseAuthSubject.java index bade77592d85d..e6cc4022bc6ee 100644 --- a/enterprise/security/src/main/java/org/neo4j/server/security/enterprise/auth/StandardEnterpriseAuthSubject.java +++ b/enterprise/security/src/main/java/org/neo4j/server/security/enterprise/auth/StandardEnterpriseAuthSubject.java @@ -73,11 +73,11 @@ public void setPassword( String password, boolean requirePasswordChange ) { getUserManager().setUserPassword( shiroSubject.getPrincipal().toString(), password, requirePasswordChange ); // Make user authenticated if successful - passwordChangeNoLongerRequired(); + setPasswordChangeNoLongerRequired(); } @Override - public void passwordChangeNoLongerRequired() + public void setPasswordChangeNoLongerRequired() { if ( getAuthenticationResult() == AuthenticationResult.PASSWORD_CHANGE_REQUIRED ) { diff --git a/enterprise/security/src/main/java/org/neo4j/server/security/enterprise/auth/UserManagementProcedures.java b/enterprise/security/src/main/java/org/neo4j/server/security/enterprise/auth/UserManagementProcedures.java index 8b684ab8b4c3c..4361aec958f3e 100644 --- a/enterprise/security/src/main/java/org/neo4j/server/security/enterprise/auth/UserManagementProcedures.java +++ b/enterprise/security/src/main/java/org/neo4j/server/security/enterprise/auth/UserManagementProcedures.java @@ -70,7 +70,7 @@ public void changeUserPassword( @Name( "username" ) String username, @Name( "new userManager.setUserPassword( username, newPassword, requirePasswordChange ); if ( authSubject.hasUsername( username ) ) { - authSubject.passwordChangeNoLongerRequired(); + authSubject.setPasswordChangeNoLongerRequired(); } } diff --git a/enterprise/security/src/test/java/org/neo4j/server/security/enterprise/auth/EmbeddedBuiltInProceduresInteractionTest.java b/enterprise/security/src/test/java/org/neo4j/server/security/enterprise/auth/EmbeddedBuiltInProceduresInteractionTest.java index 648d4d3fda8c7..8fd6b12563129 100644 --- a/enterprise/security/src/test/java/org/neo4j/server/security/enterprise/auth/EmbeddedBuiltInProceduresInteractionTest.java +++ b/enterprise/security/src/test/java/org/neo4j/server/security/enterprise/auth/EmbeddedBuiltInProceduresInteractionTest.java @@ -161,7 +161,7 @@ public void setPassword( String password, boolean requirePasswordChange ) } @Override - public void passwordChangeNoLongerRequired() + public void setPasswordChangeNoLongerRequired() { }