Fixes bug in pattern matching around pruning var expand #10359
Merged
+38
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lojjs
approved these changes
Oct 31, 2017
Lojjs
force-pushed
the
3.2-pruning-varexpand-bug
branch
2 times, most recently
from
7af31df
to
0db6e89
Compare
When both sides of a variable path where already available, pruning var-expand should not be used, since it disregards the already bound end-side.
Lojjs
force-pushed
the
3.2-pruning-varexpand-bug
branch
from
0db6e89
to
23f3835
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When both sides of a variable path where already available,
pruning var-expand should not be used, since it disregards the already
bound end-side.