Release lock client in KTI #6075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since those instances are hard wired to a specific Locks instance. Other similar references are always kept on the service level, like CommitProcess, where there's a proxy in between which switches when role switches. This commit undos parts of #5817 because of the issue described in #5996 and because this solution where Locks is referenced conforms with other types of references and is a simpler fix to the original problem.
|
HA-robustness test for this branch is green. Thus |
|
@lutovich @tinwelint PR looks fine |
MishaDemianenko
added a commit
that referenced
this pull request
Dec 14, 2015
Release lock client in KTI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KernelTransactionImplementationdoesn't referenceLocks.Clientsince those instances are hard wired to a specificLocksinstance. Other similar references are always kept on the service level, likeCommitProcess, where there's a proxy in between which switches when role switches.This commit undos parts of #5817 because of the issue described in #5996 and because this solution where
Locksis referenced conforms with other types of references and is a simpler fix to the original problem.NOTE: merge of this PR to 3.0 should be a null-merge.